You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/08/18 19:00:45 UTC
Review Request 61748: Style cleanup for grpc tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61748/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Jie Yu.
Repository: mesos
Description
-------
Style cleanup for grpc tests.
Diffs
-----
3rdparty/libprocess/src/tests/grpc_tests.cpp a11b6f02e59b83934a5fe9c62f68e7a361601a94
Diff: https://reviews.apache.org/r/61748/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 61748: Style cleanup for grpc tests.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61748/#review183257
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 18, 2017, 7 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61748/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2017, 7 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Style cleanup for grpc tests.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/grpc_tests.cpp a11b6f02e59b83934a5fe9c62f68e7a361601a94
>
>
> Diff: https://reviews.apache.org/r/61748/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61748: Style cleanup for grpc tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61748/#review183256
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61600, 61748]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On Aug. 18, 2017, 7 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61748/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2017, 7 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Style cleanup for grpc tests.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/grpc_tests.cpp a11b6f02e59b83934a5fe9c62f68e7a361601a94
>
>
> Diff: https://reviews.apache.org/r/61748/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>