[GitHub] [pulsar] AnonHxy commented on a diff in pull request #20286: [fix][test] Flaky-test: SimpleProducerConsumerTestStreamingDispatcherTest. rest

["AnonHxy (via GitHub)" <gi...@apache.org>]

AnonHxy commented on code in PR #20286:
URL: https://github.com/apache/pulsar/pull/20286#discussion_r1189584202


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceTest.java:
##########
@@ -172,8 +172,6 @@ public void testShutDownWithMaxConcurrentUnload() throws Exception {
             assertTrue(e instanceof PulsarClientException.TimeoutException);
         }
 
-        pulsar = null;

Review Comment:
   `BrokerServiceTest` and `SimpleProducerConsumerTestStreamingDispatcherTest` both are subclass of `MockedPulsarServiceBaseTest`.  So the conection is that they will call the same `MockedPulsarServiceBaseTest#pulsar`.
   
   In addition, `MockedPulsarServiceBaseTest` has other subclasses also call `MockedPulsarServiceBaseTest#pulsar`, so here we'd better remove this line. @michaeljmarshall 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org