You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/05 05:34:47 UTC
Review Request: Added protobuf into libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9743/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
Part 1 of the fix for MESOS-376 (libprocess only changes).
This addresses bug MESOS-376.
https://issues.apache.org/jira/browse/MESOS-376
Diffs
-----
third_party/libprocess/Makefile.am 71eb6805e5699984797389bb15f6d9f2c6d26b44
third_party/libprocess/third_party/Makefile.am c3f19b383743dcfae6b165c28077d2c7a483eb5d
third_party/libprocess/third_party/protobuf-2.4.1.tar.gz PRE-CREATION
third_party/libprocess/third_party/versions.am 283b3683b79b5728241fe5b8b114127eecf9e8f2
Diff: https://reviews.apache.org/r/9743/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Added protobuf into libprocess.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9743/#review17405
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On March 5, 2013, 4:34 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9743/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 4:34 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Part 1 of the fix for MESOS-376 (libprocess only changes).
>
>
> This addresses bug MESOS-376.
> https://issues.apache.org/jira/browse/MESOS-376
>
>
> Diffs
> -----
>
> third_party/libprocess/Makefile.am 71eb6805e5699984797389bb15f6d9f2c6d26b44
> third_party/libprocess/third_party/Makefile.am c3f19b383743dcfae6b165c28077d2c7a483eb5d
> third_party/libprocess/third_party/protobuf-2.4.1.tar.gz PRE-CREATION
> third_party/libprocess/third_party/versions.am 283b3683b79b5728241fe5b8b114127eecf9e8f2
>
> Diff: https://reviews.apache.org/r/9743/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added protobuf into libprocess.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9743/#review17416
-----------------------------------------------------------
third_party/libprocess/third_party/Makefile.am
<https://reviews.apache.org/r/9743/#comment36947>
I would have expected libprotobuf.la to be here too?
- Benjamin Hindman
On March 5, 2013, 4:34 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9743/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 4:34 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Part 1 of the fix for MESOS-376 (libprocess only changes).
>
>
> This addresses bug MESOS-376.
> https://issues.apache.org/jira/browse/MESOS-376
>
>
> Diffs
> -----
>
> third_party/libprocess/Makefile.am 71eb6805e5699984797389bb15f6d9f2c6d26b44
> third_party/libprocess/third_party/Makefile.am c3f19b383743dcfae6b165c28077d2c7a483eb5d
> third_party/libprocess/third_party/protobuf-2.4.1.tar.gz PRE-CREATION
> third_party/libprocess/third_party/versions.am 283b3683b79b5728241fe5b8b114127eecf9e8f2
>
> Diff: https://reviews.apache.org/r/9743/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added protobuf into libprocess.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9743/
-----------------------------------------------------------
(Updated March 5, 2013, 8:33 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
benh review
Description
-------
Part 1 of the fix for MESOS-376 (libprocess only changes).
This addresses bug MESOS-376.
https://issues.apache.org/jira/browse/MESOS-376
Diffs (updated)
-----
third_party/libprocess/Makefile.am 71eb6805e5699984797389bb15f6d9f2c6d26b44
third_party/libprocess/third_party/Makefile.am c3f19b383743dcfae6b165c28077d2c7a483eb5d
third_party/libprocess/third_party/protobuf-2.4.1.tar.gz PRE-CREATION
third_party/libprocess/third_party/versions.am 283b3683b79b5728241fe5b8b114127eecf9e8f2
Diff: https://reviews.apache.org/r/9743/diff/
Testing
-------
make check
Thanks,
Ben Mahler