You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "anishshri-db (via GitHub)" <gi...@apache.org> on 2023/05/15 05:55:51 UTC

[GitHub] [spark] anishshri-db commented on pull request #41122: [SPARK-43436][BUILD] Upgrade rocksdbjni to 8.1.1.1

anishshri-db commented on PR #41122:
URL: https://github.com/apache/spark/pull/41122#issuecomment-1547231543

   @LuciferYang - As @HeartSaVioR mentioned, this is part of our broader effort to reduce memory usage for rocksdb. As part of that change, we don't use writeBatch any more and have also moved to disable the write ahead log. As part of this, puts/deletes will be written to memtables and gets will also be served from memtables/block cache which might lead to some difference in perf for those options. We can cover up for most of that since the db write during commit is now eliminated and we can also do periodic flushing with a related upcoming change.
   
   Could you let me know which b/mark test will fail and how we run that ?
   
   @HeartSaVioR - do you proposing changing the b/mark itself ? or rerunning and updating the results page ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org