You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/14 14:59:20 UTC
[GitHub] [skywalking] 807801002 opened a new issue #6755: Support collecting threadpool metrics by agent-core
807801002 opened a new issue #6755:
URL: https://github.com/apache/skywalking/issues/6755
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [x] Question or discussion
- [ ] Bug
- [ ] Requirement
- [ ] Feature or performance improvement
___
### Question
- What do you want to know?
Can Skywalking support extension development in agent.core by intercepting the ThreadPoolExecutor class constructor?Way through the onConstruct InstanceConstructorInterceptor class objInst parameters corresponding to the instance,Then periodically collect ThreadPoolExecutor instance's thread pool metrics and construct new metric to implement thread pool monitoring
skywalking能否支持在agent.core扩展开发通过拦截ThreadPoolExecutor类构造器的方式，通过InstanceConstructorInterceptor类的onConstruct方法的objInst参数获取对应instance，然后定时采集ThreadPoolExecutor实例的线程池指标构造成新的metric来实现针对线程池的监控
___
### Bug
- Which version of SkyWalking, OS, and JRE?
- Which company or project?
- What happened?
If possible, provide a way to reproduce the error. e.g. demo application, component version.
___
### Requirement or improvement
- Please describe your requirements or improvement suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #6755: Support collecting threadpool metrics by agent-core
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6755:
URL: https://github.com/apache/skywalking/issues/6755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6755: Support collecting threadpool metrics by agent-core
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6755:
URL: https://github.com/apache/skywalking/issues/6755#issuecomment-819595160
Please keep all things in English. We need this readable for global. And the meter APIs exist for a while. Read plugin development doc, https://skywalking.apache.org/docs/main/v8.5.0/en/guides/java-plugin-development-guide/#meter-plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] 807801002 edited a comment on issue #6755: Support collecting threadpool metrics by agent-core
Posted by GitBox <gi...@apache.org>.
807801002 edited a comment on issue #6755:
URL: https://github.com/apache/skywalking/issues/6755#issuecomment-819592596
就是想在agent-core中新建一个包，然后通过InstanceConstructorInterceptor类来拦截ThreadPoolExecutor这个类，通过onConstruct方法的objInst参数获取对应instance，开启定时器去定时采集实例对应的线程池指标（PoolSize、ActiveCount、CorePoolSize、MaximumPoolSize、TaskCount等），上报到oap-server。这个方式可行不？或者说有什么其他建议可行的方式实现采集线程池指标来实现对线程池的监控？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6755: Support collecting threadpool metrics by agent-core
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6755:
URL: https://github.com/apache/skywalking/issues/6755#issuecomment-819587406
What do you mean `Can`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] 807801002 edited a comment on issue #6755: Support collecting threadpool metrics by agent-core
Posted by GitBox <gi...@apache.org>.
807801002 edited a comment on issue #6755:
URL: https://github.com/apache/skywalking/issues/6755#issuecomment-819592596
I Just want to create a new package in the agent - the core, and then through InstanceConstructorInterceptor class to intercept ThreadPoolExecutor this class, through the onConstruct method objInst parameters corresponding to the instance,Start the timer to collect the corresponding thread pool indicators (PoolSize, ActiveCount, CorePoolSize, MaximumPoolSize, TaskCount, etc.) of the instance on a regular basis, and report them to OAP-Server.Does it work?Or are there any other suggested ways to monitor the thread pool by collecting thread pool metrics?
就是想在agent-core中新建一个包，然后通过InstanceConstructorInterceptor类来拦截ThreadPoolExecutor这个类，通过onConstruct方法的objInst参数获取对应instance，开启定时器去定时采集实例对应的线程池指标（PoolSize、ActiveCount、CorePoolSize、MaximumPoolSize、TaskCount等），上报到oap-server。这个方式可行不？或者说有什么其他建议可行的方式实现采集线程池指标来实现对线程池的监控？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] 807801002 commented on issue #6755: Support collecting threadpool metrics by agent-core
Posted by GitBox <gi...@apache.org>.
807801002 commented on issue #6755:
URL: https://github.com/apache/skywalking/issues/6755#issuecomment-819592596
就是想在agent-core中新建一个包，然后通过InstanceConstructorInterceptor类来拦截ThreadPoolExecutor这个类，通过onConstruct方法的objInst参数获取对应instance，开启定时器去定时采集实例对应的线程池指标（PoolSize、ActiveCount、CorePoolSize、MaximumPoolSize、TaskCount等），上报到oap-server。这个方式可行不？或者说有什么其他方式可以采集线程池指标来实现对线程池的监控？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org