You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/06 17:11:06 UTC

[GitHub] [arrow-rs] viirya commented on a diff in pull request #1664: Replace `fn is_large` with `const IS_LARGE`

viirya commented on code in PR #1664:
URL: https://github.com/apache/arrow-rs/pull/1664#discussion_r867021100


##########
arrow/src/array/array_binary.rs:
##########
@@ -44,8 +44,11 @@ pub struct GenericBinaryArray<OffsetSize: OffsetSizeTrait> {
 }
 
 impl<OffsetSize: OffsetSizeTrait> GenericBinaryArray<OffsetSize> {
+    /// Get the data type of the array.
+    // Declare this function as `pub const fn` after
+    // https://github.com/rust-lang/rust/issues/93706 is merged.

Review Comment:
   Make consistent comment style?
   ```suggestion
       // Get the data type of the array.
       // Declare this function as `pub const fn` after
       // https://github.com/rust-lang/rust/issues/93706 is merged.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org