[GitHub] [hudi] yihua commented on a diff in pull request #6631: [HUDI-4810] Fixing Hudi bundles requiring log4j2 on the classpath

[GitBox <gi...@apache.org>]

yihua commented on code in PR #6631:
URL: https://github.com/apache/hudi/pull/6631#discussion_r967525721


##########
hudi-cli/pom.xml:
##########
@@ -139,6 +139,12 @@
       <version>${scala.version}</version>
     </dependency>
 
+    <!-- Logging -->
+    <dependency>
+      <groupId>org.apache.logging.log4j</groupId>
+      <artifactId>log4j-1.2-api</artifactId>
+    </dependency>

Review Comment:
   Similar here and in other modules. 



##########
hudi-aws/pom.xml:
##########
@@ -34,6 +34,12 @@
     </properties>
 
     <dependencies>
+        <!-- Logging -->
+        <dependency>
+            <groupId>org.apache.logging.log4j</groupId>
+            <artifactId>log4j-1.2-api</artifactId>
+        </dependency>

Review Comment:
   Should this already be included as a transitive dependency, introduced by `hudi-common` module?



##########
hudi-client/hudi-flink-client/pom.xml:
##########
@@ -35,7 +35,21 @@
     </properties>
 
     <dependencies>
-        <!-- Hudi  -->
+        <!-- Logging -->
+    <dependency>
+      <groupId>org.apache.logging.log4j</groupId>
+      <artifactId>log4j-1.2-api</artifactId>
+    </dependency>
+    <dependency>
+      <groupId>org.apache.logging.log4j</groupId>
+      <artifactId>log4j-slf4j-impl</artifactId>
+    </dependency>
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-api</artifactId>
+    </dependency>

Review Comment:
   nit: Indentation is off?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org