You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Marton Greber (Code Review)" <ge...@cloudera.org> on 2023/03/06 17:27:39 UTC

[kudu-CR] [Python] Add support for immutable column

Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19586


Change subject: [Python] Add support for immutable column
......................................................................

[Python] Add support for immutable column

This patch is a followup on: f20dcf57ad76e9b1bb57fe60b27ea3a8f02df233,
it introduces the immutable column type in the Python client.

There is a slight difference compared to the C++ API. In the C++ client
one can set two type of KuduColumnSpec: immutable or mutable. In the
Python client there is a single mutable ColumnSpec, which accepts a
boolean value. This is not a new type of difference between the clients,
for example the nullability works the same way, in terms of client
implementations.

Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
---
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_client.py
M python/kudu/tests/test_schema.py
4 files changed, 135 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/19586/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
Gerrit-Change-Number: 19586
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>

[kudu-CR] [Python] Add support for immutable column

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yingchun Lai, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19586

to look at the new patch set (#4).

Change subject: [Python] Add support for immutable column
......................................................................

[Python] Add support for immutable column

This patch is a followup on: f20dcf57ad76e9b1bb57fe60b27ea3a8f02df233,
it introduces the immutable column type in the Python client.

There is a slight difference compared to the C++ API. In the C++ client
one can set two type of KuduColumnSpec: immutable or mutable. In the
Python client there is a single mutable ColumnSpec, which accepts a
boolean value. This is not a new type of difference between the clients,
for example the nullability works the same way, in terms of client
implementations.

Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
---
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_client.py
M python/kudu/tests/test_schema.py
4 files changed, 135 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/19586/4
-- 
To view, visit http://gerrit.cloudera.org:8080/19586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
Gerrit-Change-Number: 19586
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>

[kudu-CR] [Python] Add support for immutable column

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19586 )

Change subject: [Python] Add support for immutable column
......................................................................


Patch Set 1:

@Marton Greber, could you please to resolve the merge conflict?


-- 
To view, visit http://gerrit.cloudera.org:8080/19586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
Gerrit-Change-Number: 19586
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 14 Mar 2023 03:56:33 +0000
Gerrit-HasComments: No

[kudu-CR] [Python] Add support for immutable column

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19586 )

Change subject: [Python] Add support for immutable column
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
Gerrit-Change-Number: 19586
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Wed, 08 Mar 2023 07:28:52 +0000
Gerrit-HasComments: No

[kudu-CR] [Python] Add support for immutable column

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19586 )

Change subject: [Python] Add support for immutable column
......................................................................

[Python] Add support for immutable column

This patch is a followup on: f20dcf57ad76e9b1bb57fe60b27ea3a8f02df233,
it introduces the immutable column type in the Python client.

There is a slight difference compared to the C++ API. In the C++ client
one can set two type of KuduColumnSpec: immutable or mutable. In the
Python client there is a single mutable ColumnSpec, which accepts a
boolean value. This is not a new type of difference between the clients,
for example the nullability works the same way, in terms of client
implementations.

Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
Reviewed-on: http://gerrit.cloudera.org:8080/19586
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <la...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_client.py
M python/kudu/tests/test_schema.py
4 files changed, 135 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Yingchun Lai: Looks good to me, approved
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/19586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
Gerrit-Change-Number: 19586
Gerrit-PatchSet: 6
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>

[kudu-CR] [Python] Add support for immutable column

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yingchun Lai, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19586

to look at the new patch set (#3).

Change subject: [Python] Add support for immutable column
......................................................................

[Python] Add support for immutable column

This patch is a followup on: f20dcf57ad76e9b1bb57fe60b27ea3a8f02df233,
it introduces the immutable column type in the Python client.

There is a slight difference compared to the C++ API. In the C++ client
one can set two type of KuduColumnSpec: immutable or mutable. In the
Python client there is a single mutable ColumnSpec, which accepts a
boolean value. This is not a new type of difference between the clients,
for example the nullability works the same way, in terms of client
implementations.

Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
---
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_client.py
M python/kudu/tests/test_schema.py
4 files changed, 135 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/19586/3
-- 
To view, visit http://gerrit.cloudera.org:8080/19586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
Gerrit-Change-Number: 19586
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>

[kudu-CR] [Python] Add support for immutable column

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yingchun Lai, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19586

to look at the new patch set (#5).

Change subject: [Python] Add support for immutable column
......................................................................

[Python] Add support for immutable column

This patch is a followup on: f20dcf57ad76e9b1bb57fe60b27ea3a8f02df233,
it introduces the immutable column type in the Python client.

There is a slight difference compared to the C++ API. In the C++ client
one can set two type of KuduColumnSpec: immutable or mutable. In the
Python client there is a single mutable ColumnSpec, which accepts a
boolean value. This is not a new type of difference between the clients,
for example the nullability works the same way, in terms of client
implementations.

Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
---
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_client.py
M python/kudu/tests/test_schema.py
4 files changed, 135 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/19586/5
-- 
To view, visit http://gerrit.cloudera.org:8080/19586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
Gerrit-Change-Number: 19586
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>

[kudu-CR] [Python] Add support for immutable column

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19586 )

Change subject: [Python] Add support for immutable column
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
Gerrit-Change-Number: 19586
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 20 Mar 2023 02:25:16 +0000
Gerrit-HasComments: No

[kudu-CR] [Python] Add support for immutable column

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19586 )

Change subject: [Python] Add support for immutable column
......................................................................


Patch Set 1: Code-Review+1

Thank you very much to implement the Pyhton client part of immutable column.


-- 
To view, visit http://gerrit.cloudera.org:8080/19586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
Gerrit-Change-Number: 19586
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 07 Mar 2023 16:47:15 +0000
Gerrit-HasComments: No

[kudu-CR] [Python] Add support for immutable column

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19586 )

Change subject: [Python] Add support for immutable column
......................................................................


Patch Set 5:

Sorry about the delay! I was waiting for 80a18400024d36f84c7fa53eac0fba8e2f8b726d to be merged, as there was some import change which this patch depends on.
Did rebase the patch. Thanks for your patience!


-- 
To view, visit http://gerrit.cloudera.org:8080/19586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
Gerrit-Change-Number: 19586
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sun, 19 Mar 2023 18:46:10 +0000
Gerrit-HasComments: No

[kudu-CR] [Python] Add support for immutable column

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19586 )

Change subject: [Python] Add support for immutable column
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09bc3fe54ea7b40ccefa046c668e3622794b22e9
Gerrit-Change-Number: 19586
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 20 Mar 2023 04:32:22 +0000
Gerrit-HasComments: No