You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/07/17 17:14:00 UTC
[GitHub] szha commented on a change in pull request #11780: fix flaky test
test_operator_gpu.test_countsketch
szha commented on a change in pull request #11780: fix flaky test test_operator_gpu.test_countsketch
URL: https://github.com/apache/incubator-mxnet/pull/11780#discussion_r203105645
##########
File path: src/operator/contrib/count_sketch.cu
##########
@@ -129,8 +129,7 @@ inline void CountSketchForward(const Tensor<gpu, 2, DType> &out,
nthreads, out_ptr+bstart*out_dim, h_ptr,
s_ptr, in_ptr+bstart*in_dim, batchlen,
in_dim, out_dim);
- MSHADOW_CUDA_POST_KERNEL_CHECK(sketch_forward_kernel);
- // cudaThreadSynchronize();
+ CHECK_EQ(cudaDeviceSynchronize(), cudaSuccess) << "Problem occured!";
Review comment:
Consider adding more info to the log (e.g. cudaSuccess value).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services