You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "papdaniel (via GitHub)" <gi...@apache.org> on 2025/03/21 08:32:49 UTC
[PR] feat(ip-restriction): support 404 response code [apisix]
papdaniel opened a new pull request, #12076:
URL: https://github.com/apache/apisix/pull/12076
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Support 404 response code to hide the route from blacklisted/not whitelisted sources
Fixes # ([12056](https://github.com/apache/apisix/issues/12056))
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ip-restriction): support 404 response code [apisix]
Posted by "papdaniel (via GitHub)" <gi...@apache.org>.
papdaniel commented on PR #12076:
URL: https://github.com/apache/apisix/pull/12076#issuecomment-2742682559
I think making response code configurable to 404 is enough. Should we support any response codes, or any 4xx codes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ip-restriction): support 404 response code [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop merged PR #12076:
URL: https://github.com/apache/apisix/pull/12076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ip-restriction): support 404 response code [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #12076:
URL: https://github.com/apache/apisix/pull/12076#issuecomment-2742910134
Personally I think any 4xx code should be configurable, looking forward to other more comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org