You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/07/23 15:14:14 UTC
[GitHub] [hbase-thirdparty] Apache9 opened a new pull request #22: HBASE-19256 [hbase-thirdparty] shade jetty
Apache9 opened a new pull request #22:
URL: https://github.com/apache/hbase-thirdparty/pull/22
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-thirdparty] Apache9 merged pull request #22: HBASE-19256 [hbase-thirdparty] shade jetty
Posted by GitBox <gi...@apache.org>.
Apache9 merged pull request #22:
URL: https://github.com/apache/hbase-thirdparty/pull/22
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-thirdparty] Apache9 commented on a change in pull request #22: HBASE-19256 [hbase-thirdparty] shade jetty
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #22:
URL: https://github.com/apache/hbase-thirdparty/pull/22#discussion_r460387373
##########
File path: pom.xml
##########
@@ -134,6 +136,13 @@
<commons-collections.version>4.4</commons-collections.version>
<error_prone_annotations.version>2.3.4</error_prone_annotations.version>
<gson.version>2.8.5</gson.version>
+ <jetty.version>9.4.30.v20200611</jetty.version>
Review comment:
Seems not in maven central yet?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-thirdparty] Apache9 commented on pull request #22: HBASE-19256 [hbase-thirdparty] shade jetty
Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #22:
URL: https://github.com/apache/hbase-thirdparty/pull/22#issuecomment-664729832
> Glancing at the jars, I see some ServiceLoader entries in both the jetty and jersey jars. I _think_ this would break, if we happen to use it, given the entry in the jar and the values in the file are both pointing at unshaded locations.
>
> The maven-shade-plugin does have a transformer for these https://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html#ServicesResourceTransformer. It might be just as easy as enabling that along with the others you already have.
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-thirdparty] joshelser commented on pull request #22: HBASE-19256 [hbase-thirdparty] shade jetty
Posted by GitBox <gi...@apache.org>.
joshelser commented on pull request #22:
URL: https://github.com/apache/hbase-thirdparty/pull/22#issuecomment-664726639
Glancing at the jars, I see some ServiceLoader entries in both the jetty and jersey jars. I _think_ this would break, if we happen to use it, given the entry in the jar and the values in the file are both pointing at unshaded locations.
The maven-shade-plugin does have a transformer for these https://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html#ServicesResourceTransformer. It might be just as easy as enabling that along with the others you already have.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-thirdparty] Apache9 commented on pull request #22: HBASE-19256 [hbase-thirdparty] shade jetty
Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #22:
URL: https://github.com/apache/hbase-thirdparty/pull/22#issuecomment-663065833
Still need to take a look at the jersey part. We need to exclude the general API jar, just like what I have done for jetty, to exclude servlet-api.
> [INFO] Including org.glassfish.jersey.containers:jersey-container-servlet-core:jar:2.31 in the shaded jar.
[INFO] Including org.glassfish.hk2.external:jakarta.inject:jar:2.6.1 in the shaded jar.
[INFO] Including org.glassfish.jersey.core:jersey-common:jar:2.31 in the shaded jar.
[INFO] Including org.glassfish.hk2:osgi-resource-locator:jar:1.0.3 in the shaded jar.
[INFO] Including jakarta.ws.rs:jakarta.ws.rs-api:jar:2.1.6 in the shaded jar.
[INFO] Including org.glassfish.jersey.core:jersey-client:jar:2.31 in the shaded jar.
[INFO] Including org.glassfish.jersey.core:jersey-server:jar:2.31 in the shaded jar.
[INFO] Including org.glassfish.jersey.media:jersey-media-jaxb:jar:2.31 in the shaded jar.
[INFO] Including jakarta.annotation:jakarta.annotation-api:jar:1.3.5 in the shaded jar.
[INFO] Including jakarta.validation:jakarta.validation-api:jar:2.0.2 in the shaded jar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-thirdparty] Apache9 commented on a change in pull request #22: HBASE-19256 [hbase-thirdparty] shade jetty
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #22:
URL: https://github.com/apache/hbase-thirdparty/pull/22#discussion_r461268469
##########
File path: hbase-shaded-jetty/pom.xml
##########
@@ -0,0 +1,166 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+ ON MVN COMPILE NOT WORKING
+
+ If you wondering why 'mvn compile' does not work building HBase
+ (in particular, if you are doing it for the first time), instead do
+ 'mvn package'. If you are interested in the full story, see
+ https://issues.apache.org/jira/browse/HBASE-6795.
+
+-->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-thirdparty</artifactId>
+ <version>3.3.1-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <artifactId>hbase-shaded-jetty</artifactId>
+ <name>Apache HBase Relocated (Shaded) Jetty Libs</name>
+ <description>
+ Pulls down Jetty, relocates it and makes a far jar.
+ </description>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-clean-plugin</artifactId>
+ <configuration>
+ <filesets>
+ <fileset>
+ <directory>${basedir}</directory>
+ <includes>
+ <include>dependency-reduced-pom.xml</include>
+ </includes>
+ </fileset>
+ </filesets>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <shadeSourcesContent>true</shadeSourcesContent>
+ <createSourcesJar>true</createSourcesJar>
+ <relocations>
+ <relocation>
+ <pattern>org.eclipse.jetty</pattern>
+ <shadedPattern>${rename.offset}.org.eclipse.jetty</shadedPattern>
+ </relocation>
+ </relocations>
+ <artifactSet>
+ <excludes>
+ <!--
+ Anything added here needs to be excluded from the jar that pulls it in
+ also else we give an odd signal in the META-INF/DEPENDENCIES that we
+ produce. See below for how to exclusion of transitive dependencies.
+ -->
+ <exclude>javax.servlet:javax.servlet-api</exclude>
+ </excludes>
+ </artifactSet>
+ <transformers>
+ <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer">
+ </transformer>
+ <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer">
+ <addHeader>false</addHeader>
+ </transformer>
+ </transformers>
+ <filters>
+ <filter>
+ <artifact>org.eclipse.jetty:*</artifact>
+ <excludes>
+ <exclude>about.html</exclude>
+ <exclude>jetty-dir.css</exclude>
Review comment:
Let's get them back.
##########
File path: hbase-shaded-jetty/pom.xml
##########
@@ -0,0 +1,166 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+ ON MVN COMPILE NOT WORKING
+
+ If you wondering why 'mvn compile' does not work building HBase
+ (in particular, if you are doing it for the first time), instead do
+ 'mvn package'. If you are interested in the full story, see
+ https://issues.apache.org/jira/browse/HBASE-6795.
+
+-->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-thirdparty</artifactId>
+ <version>3.3.1-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <artifactId>hbase-shaded-jetty</artifactId>
+ <name>Apache HBase Relocated (Shaded) Jetty Libs</name>
+ <description>
+ Pulls down Jetty, relocates it and makes a far jar.
+ </description>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-clean-plugin</artifactId>
+ <configuration>
+ <filesets>
+ <fileset>
+ <directory>${basedir}</directory>
+ <includes>
+ <include>dependency-reduced-pom.xml</include>
+ </includes>
+ </fileset>
+ </filesets>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <shadeSourcesContent>true</shadeSourcesContent>
+ <createSourcesJar>true</createSourcesJar>
+ <relocations>
+ <relocation>
+ <pattern>org.eclipse.jetty</pattern>
+ <shadedPattern>${rename.offset}.org.eclipse.jetty</shadedPattern>
+ </relocation>
+ </relocations>
+ <artifactSet>
+ <excludes>
+ <!--
+ Anything added here needs to be excluded from the jar that pulls it in
+ also else we give an odd signal in the META-INF/DEPENDENCIES that we
+ produce. See below for how to exclusion of transitive dependencies.
+ -->
+ <exclude>javax.servlet:javax.servlet-api</exclude>
+ </excludes>
+ </artifactSet>
+ <transformers>
+ <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer">
+ </transformer>
+ <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer">
+ <addHeader>false</addHeader>
+ </transformer>
+ </transformers>
+ <filters>
+ <filter>
+ <artifact>org.eclipse.jetty:*</artifact>
+ <excludes>
+ <exclude>about.html</exclude>
+ <exclude>jetty-dir.css</exclude>
Review comment:
It is a pain that these resources are located at '/', not in a package. I assume it could be conflict with unshaded jetty...
But I do not think the content will be much differences between jetty 9.3 and 9.4, so I do not think it will be a blocker for now, but we need to find out a way to deal this in the future.
##########
File path: hbase-shaded-jetty/pom.xml
##########
@@ -0,0 +1,166 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+ ON MVN COMPILE NOT WORKING
+
+ If you wondering why 'mvn compile' does not work building HBase
+ (in particular, if you are doing it for the first time), instead do
+ 'mvn package'. If you are interested in the full story, see
+ https://issues.apache.org/jira/browse/HBASE-6795.
+
+-->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-thirdparty</artifactId>
+ <version>3.3.1-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <artifactId>hbase-shaded-jetty</artifactId>
+ <name>Apache HBase Relocated (Shaded) Jetty Libs</name>
+ <description>
+ Pulls down Jetty, relocates it and makes a far jar.
+ </description>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-clean-plugin</artifactId>
+ <configuration>
+ <filesets>
+ <fileset>
+ <directory>${basedir}</directory>
+ <includes>
+ <include>dependency-reduced-pom.xml</include>
+ </includes>
+ </fileset>
+ </filesets>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <shadeSourcesContent>true</shadeSourcesContent>
+ <createSourcesJar>true</createSourcesJar>
+ <relocations>
+ <relocation>
+ <pattern>org.eclipse.jetty</pattern>
+ <shadedPattern>${rename.offset}.org.eclipse.jetty</shadedPattern>
+ </relocation>
+ </relocations>
+ <artifactSet>
+ <excludes>
+ <!--
+ Anything added here needs to be excluded from the jar that pulls it in
+ also else we give an odd signal in the META-INF/DEPENDENCIES that we
+ produce. See below for how to exclusion of transitive dependencies.
+ -->
+ <exclude>javax.servlet:javax.servlet-api</exclude>
+ </excludes>
+ </artifactSet>
+ <transformers>
+ <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer">
+ </transformer>
+ <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer">
+ <addHeader>false</addHeader>
+ </transformer>
+ </transformers>
+ <filters>
+ <filter>
+ <artifact>org.eclipse.jetty:*</artifact>
+ <excludes>
+ <exclude>about.html</exclude>
+ <exclude>jetty-dir.css</exclude>
Review comment:
Oh, I added them back. I mean the conflict is not a big deal for now...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-thirdparty] joshelser commented on a change in pull request #22: HBASE-19256 [hbase-thirdparty] shade jetty
Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #22:
URL: https://github.com/apache/hbase-thirdparty/pull/22#discussion_r461265897
##########
File path: pom.xml
##########
@@ -134,6 +136,13 @@
<commons-collections.version>4.4</commons-collections.version>
<error_prone_annotations.version>2.3.4</error_prone_annotations.version>
<gson.version>2.8.5</gson.version>
+ <jetty.version>9.4.30.v20200611</jetty.version>
Review comment:
Hrm, right you are. Funny. Can get it next time.
##########
File path: hbase-shaded-jetty/pom.xml
##########
@@ -0,0 +1,166 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+ ON MVN COMPILE NOT WORKING
+
+ If you wondering why 'mvn compile' does not work building HBase
+ (in particular, if you are doing it for the first time), instead do
+ 'mvn package'. If you are interested in the full story, see
+ https://issues.apache.org/jira/browse/HBASE-6795.
+
+-->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-thirdparty</artifactId>
+ <version>3.3.1-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <artifactId>hbase-shaded-jetty</artifactId>
+ <name>Apache HBase Relocated (Shaded) Jetty Libs</name>
+ <description>
+ Pulls down Jetty, relocates it and makes a far jar.
+ </description>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-clean-plugin</artifactId>
+ <configuration>
+ <filesets>
+ <fileset>
+ <directory>${basedir}</directory>
+ <includes>
+ <include>dependency-reduced-pom.xml</include>
+ </includes>
+ </fileset>
+ </filesets>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <shadeSourcesContent>true</shadeSourcesContent>
+ <createSourcesJar>true</createSourcesJar>
+ <relocations>
+ <relocation>
+ <pattern>org.eclipse.jetty</pattern>
+ <shadedPattern>${rename.offset}.org.eclipse.jetty</shadedPattern>
+ </relocation>
+ </relocations>
+ <artifactSet>
+ <excludes>
+ <!--
+ Anything added here needs to be excluded from the jar that pulls it in
+ also else we give an odd signal in the META-INF/DEPENDENCIES that we
+ produce. See below for how to exclusion of transitive dependencies.
+ -->
+ <exclude>javax.servlet:javax.servlet-api</exclude>
+ </excludes>
+ </artifactSet>
+ <transformers>
+ <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer">
+ </transformer>
+ <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer">
+ <addHeader>false</addHeader>
+ </transformer>
+ </transformers>
+ <filters>
+ <filter>
+ <artifact>org.eclipse.jetty:*</artifact>
+ <excludes>
+ <exclude>about.html</exclude>
+ <exclude>jetty-dir.css</exclude>
Review comment:
You sure we don't need this? I think this provides the stylesheet for the `LogsServlet` (e.g. Hbase UI endpoitn where you can see master/regionserver logs through the browser)
##########
File path: hbase-shaded-jetty/pom.xml
##########
@@ -0,0 +1,166 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+ ON MVN COMPILE NOT WORKING
+
+ If you wondering why 'mvn compile' does not work building HBase
+ (in particular, if you are doing it for the first time), instead do
+ 'mvn package'. If you are interested in the full story, see
+ https://issues.apache.org/jira/browse/HBASE-6795.
+
+-->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-thirdparty</artifactId>
+ <version>3.3.1-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <artifactId>hbase-shaded-jetty</artifactId>
+ <name>Apache HBase Relocated (Shaded) Jetty Libs</name>
+ <description>
+ Pulls down Jetty, relocates it and makes a far jar.
+ </description>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-clean-plugin</artifactId>
+ <configuration>
+ <filesets>
+ <fileset>
+ <directory>${basedir}</directory>
+ <includes>
+ <include>dependency-reduced-pom.xml</include>
+ </includes>
+ </fileset>
+ </filesets>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <shadeSourcesContent>true</shadeSourcesContent>
+ <createSourcesJar>true</createSourcesJar>
+ <relocations>
+ <relocation>
+ <pattern>org.eclipse.jetty</pattern>
+ <shadedPattern>${rename.offset}.org.eclipse.jetty</shadedPattern>
+ </relocation>
+ </relocations>
+ <artifactSet>
+ <excludes>
+ <!--
+ Anything added here needs to be excluded from the jar that pulls it in
+ also else we give an odd signal in the META-INF/DEPENDENCIES that we
+ produce. See below for how to exclusion of transitive dependencies.
+ -->
+ <exclude>javax.servlet:javax.servlet-api</exclude>
+ </excludes>
+ </artifactSet>
+ <transformers>
+ <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer">
+ </transformer>
+ <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer">
+ <addHeader>false</addHeader>
+ </transformer>
+ </transformers>
+ <filters>
+ <filter>
+ <artifact>org.eclipse.jetty:*</artifact>
+ <excludes>
+ <exclude>about.html</exclude>
+ <exclude>jetty-dir.css</exclude>
Review comment:
Ah, ok. Not a big deal. The page will still be functional, just not with color.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-thirdparty] Apache9 commented on pull request #22: HBASE-19256 [hbase-thirdparty] shade jetty
Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #22:
URL: https://github.com/apache/hbase-thirdparty/pull/22#issuecomment-663836388
Any other problems? I think upgrade the version of jetty is trivial...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-thirdparty] joshelser commented on a change in pull request #22: HBASE-19256 [hbase-thirdparty] shade jetty
Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #22:
URL: https://github.com/apache/hbase-thirdparty/pull/22#discussion_r460079609
##########
File path: pom.xml
##########
@@ -134,6 +136,13 @@
<commons-collections.version>4.4</commons-collections.version>
<error_prone_annotations.version>2.3.4</error_prone_annotations.version>
<gson.version>2.8.5</gson.version>
+ <jetty.version>9.4.30.v20200611</jetty.version>
Review comment:
Looks like jetty just released 9.4.31.v20200723 (yesterday)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org