[GitHub] [beam] lukecwik commented on pull request #22889: #20812 handle @RequiresStableInput in portable flink

[GitBox <gi...@apache.org>]

lukecwik commented on PR #22889:
URL: https://github.com/apache/beam/pull/22889#issuecomment-1332804200

   > @lukecwik I was looking into using the `RequiresStableInputIT`, unfortunately, it looks not easily reusable. It is somewhat used internally in some tests inside FlinkRunner (namely `FlinkRequiresStableInputTest`), but it is reused only partially. I could copy&paste the code and try to run it using Flink portable runner, but a better approach seems to be to turn it into `@ValidatesRunner` test, that could be turned on/off automatically. That looks like something orthogonal to this PR and thus I'd prefer to do it in different issue, so that we don't block this one. WDYT?
   
   I wouldn't say it is orthogonal. It is hard to have confidence that something works and isn't regressed without there being good test coverage. Your call if you still want to forge ahead without the tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org