[jira] Updated: (TRINIDAD-1511) Minor bug in the scoped id generator util class - base component being namingcontainer not handled

["Prakash Udupa N (JIRA)" <de...@myfaces.apache.org>]

     [ https://issues.apache.org/jira/browse/TRINIDAD-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prakash Udupa N updated TRINIDAD-1511:
--------------------------------------

    Status: Patch Available  (was: Open)

> Minor bug in the scoped id generator util class - base component being namingcontainer not handled
> --------------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-1511
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1511
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions:  1.2.11-core,  1.2.12-core
>         Environment: Not applicable
>            Reporter: Prakash Udupa N
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> In class org.apache.myfaces.trinidad.util.ComponentUtils:
>    * @param baseComponent The component relative to which the scoped id for the
>    * targetComponent needs to be determined.
>    * @return The scoped id for target component. Returns null if the supplied
>    * targetComponent was null or did not have an id.
>    */
>   public static String getScopedIdForComponent(
>     UIComponent targetComponent,
>     UIComponent baseComponent)
> The above method has a bug that in case the base component happens to be a NamingContainer by itself, the scoped id does not stop with the baseComponent, instead goes up one or more levels to find the NamingContainer. This breaches contract of this method, and breaks ChangeManager functionality in this corner case.
> The bug is in the private callee _getParentNamingContainer(component, baseComponent), the above case is not handled.
> Fix involves one line change, will provide the patch soon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.