You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by mcgregory <mc...@e-card.bg> on 2010/10/21 18:24:00 UTC
Re: [jira] Commented: (WICKET-3126) Drop HomePageMapper in favour
of MountedMapper("/", MyPage.class)
----- Original message -----
>
> [
> https://issues.apache.org/jira/browse/WICKET-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923492#action_12923492
> ]
>
> Martin Grigorov commented on WICKET-3126:
> -----------------------------------------
>
> "what if app.gethomepage() returns different values based on user's
> session?"
>
> This is not covered in my patch...
Currently, MountedMapper keeps a WeakReference to the page class. If change this to use IProvider instead then i think this will work too.
>
>
> > Drop HomePageMapper in favour of MountedMapper("/", MyPage.class)
> > -----------------------------------------------------------------
> >
> > Key: WICKET-3126
> > URL: https://issues.apache.org/jira/browse/WICKET-3126
> > Project: Wicket
> > Issue Type: Improvement
> > Components: wicket
> > Affects Versions: 1.5-M2.1
> > Reporter: Martin Grigorov
> > Assignee: Martin Grigorov
> > Attachments: WICKET-3126.patch, WICKET-3126.patch, WICKET-3126.patch
> >
> >
> > Currently requests to '/' are handled by HomePageMapper when the
> > request comes and by BookmarkableMapper when an Url should be created
> > (e.g. for links, forms, redirects, etc.). So requesting '/' ends with
> > URL in the browser address bar like :
> > "/wicket/bookmarkable/com.example.MyPage" (generated by
> > BookmarkableMapper). The final Url is a bit confusing to users. Here
> > is suggestion for improvement: drop HomePageMapper and use
> > MountedMapper("/", app.getHomePage()) instead. This mapper will be
> > registered after SystemMapper so it will be asked before all
> > pre-configured mappers. if the user application still wants to map
> > something else than Application#getHomePage() at "/" then it can do :
> > add(new MountedMapper("/", CustomPage.class).
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>