You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/11 17:01:29 UTC

[GitHub] [tvm-rfcs] PaulPalomeroBernardo commented on pull request #60: [RFC] UMA Universal Modular Accelerator Interface

PaulPalomeroBernardo commented on PR #60:
URL: https://github.com/apache/tvm-rfcs/pull/60#issuecomment-1124022013

   Thank you @manupa-arm for this input! I'll go over the points in more detail in the next few days.
   
   For A1,
   I agree, that enums are generally a cleaner solution. We stuck with ints until now because of the the following two reasons:
   - Phases for TIR passes are currently also int-based
   - For some Phases we struggled to find concise names
   
   I think, if we are fine with generic names for some phases until we find good names, we can switch to enums.
   
   For A2,
   I also prefer A2.1. I was prototyping something along the line and will get back with more details (and an RFC update) once it's done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org