You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/10/17 10:53:26 UTC
Review Request 63069: SENTRY-1996 - Rename Sqoop
SentryAuthorizationHander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63069/
-----------------------------------------------------------
Review request for sentry.
Bugs: SENTRY-1996
https://issues.apache.org/jira/browse/SENTRY-1996
Repository: sentry
Description
-------
This task is to rename the Sqoop SentryAuthorizationHander to SentryAuthorizationHandler. Also including a few grammatical fixes I spotted.
Diffs
-----
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java 41bd6fc2
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java 3d115e8c
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java 93bf3f30
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHandler.java PRE-CREATION
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java eae85ce5
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java 2c6d61c1
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHandler.java PRE-CREATION
sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TomcatSqoopRunner.java 2687bc52
Diff: https://reviews.apache.org/r/63069/diff/1/
Testing
-------
Thanks,
Colm O hEigeartaigh
Re: Review Request 63069: SENTRY-1996 - Rename Sqoop
SentryAuthorizationHander
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63069/#review188299
-----------------------------------------------------------
Fix it, then Ship it!
Please adddress the commit comment and push the changes.
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java
Lines 30-31 (original), 30-31 (patched)
<https://reviews.apache.org/r/63069/#comment265301>
It is could be "Sentry does not implement ".
- kalyan kumar kalvagadda
On Oct. 17, 2017, 10:53 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63069/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 10:53 a.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1996
> https://issues.apache.org/jira/browse/SENTRY-1996
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This task is to rename the Sqoop SentryAuthorizationHander to SentryAuthorizationHandler. Also including a few grammatical fixes I spotted.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/SentrySqoopError.java 41bd6fc2
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAccessController.java 3d115e8c
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHander.java 93bf3f30
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/authz/SentryAuthorizationHandler.java PRE-CREATION
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBindingSingleton.java eae85ce5
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHander.java 2c6d61c1
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/sqoop/TestSentryAuthorizationHandler.java PRE-CREATION
> sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TomcatSqoopRunner.java 2687bc52
>
>
> Diff: https://reviews.apache.org/r/63069/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>