You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ca...@apache.org on 2006/02/07 07:33:52 UTC

svn commit: r375514 - /maven/sandbox/repoclean/src/main/java/org/apache/maven/tools/repoclean/phase/RewritePhase.java

Author: carlos
Date: Mon Feb  6 22:33:51 2006
New Revision: 375514

URL: http://svn.apache.org/viewcvs?rev=375514&view=rev
Log:
Prevent making empty poms and overwritting existing ones

Modified:
    maven/sandbox/repoclean/src/main/java/org/apache/maven/tools/repoclean/phase/RewritePhase.java

Modified: maven/sandbox/repoclean/src/main/java/org/apache/maven/tools/repoclean/phase/RewritePhase.java
URL: http://svn.apache.org/viewcvs/maven/sandbox/repoclean/src/main/java/org/apache/maven/tools/repoclean/phase/RewritePhase.java?rev=375514&r1=375513&r2=375514&view=diff
==============================================================================
--- maven/sandbox/repoclean/src/main/java/org/apache/maven/tools/repoclean/phase/RewritePhase.java (original)
+++ maven/sandbox/repoclean/src/main/java/org/apache/maven/tools/repoclean/phase/RewritePhase.java Mon Feb  6 22:33:51 2006
@@ -256,19 +256,31 @@
 
         String pomContents = null;
 
-        boolean shouldRewritePom = false;
+        boolean shouldRewritePom = true;
 
-        if ( sourcePom.exists() && !targetPom.exists() )
+        if ( targetPom.exists() )
+        {
+            // we have a target pom for this artifact already, and we'll only be making up a new pom.
+            // let's leave the existing one alone.
+            artifactReporter.warn( "Not overwritting " + targetPom.getPath() );
+            return;
+        }
+
+        if ( !sourcePom.exists() )
+        {
+            // don't make empty poms
+            return;
+        }
+
+        if ( sourcePom.exists() )
         {
             pomContents = readPomContents( sourcePom );
 
             if ( pomContents.indexOf( "modelVersion" ) > -1 )
             {
+                shouldRewritePom = false;
+
                 copyMetadata( sourcePom, targetPom, transaction, artifactReporter, reportOnly );
-            }
-            else
-            {
-                shouldRewritePom = true;
             }
         }