You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2022/07/05 06:41:46 UTC

[spark] branch branch-3.3 updated: [SPARK-39676][CORE][TESTS] Add task partition id for TaskInfo assertEquals method in JsonProtocolSuite

This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch branch-3.3
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.3 by this push:
     new 3f969ada5fe [SPARK-39676][CORE][TESTS] Add task partition id for TaskInfo assertEquals method in JsonProtocolSuite
3f969ada5fe is described below

commit 3f969ada5fecddab272f2abbc849d2591f30f44c
Author: Qian.Sun <qi...@gmail.com>
AuthorDate: Tue Jul 5 15:40:44 2022 +0900

    [SPARK-39676][CORE][TESTS] Add task partition id for TaskInfo assertEquals method in JsonProtocolSuite
    
    ### What changes were proposed in this pull request?
    
    In https://github.com/apache/spark/pull/35185 , task partition id was added in taskInfo. And, JsonProtocolSuite#assertEquals about TaskInfo doesn't have partitionId.
    
    ### Why are the changes needed?
    
    Should assert partitionId equals or not.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    No need to add unit test.
    
    Closes #37081 from dcoliversun/SPARK-39676.
    
    Authored-by: Qian.Sun <qi...@gmail.com>
    Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
 core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala b/core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala
index 36b61f67e3b..3b7929b278e 100644
--- a/core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala
+++ b/core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala
@@ -790,6 +790,8 @@ private[spark] object JsonProtocolSuite extends Assertions {
     assert(info1.taskId === info2.taskId)
     assert(info1.index === info2.index)
     assert(info1.attemptNumber === info2.attemptNumber)
+    // The "Partition ID" field was added in Spark 3.3.0
+    assert(info1.partitionId === info2.partitionId)
     assert(info1.launchTime === info2.launchTime)
     assert(info1.executorId === info2.executorId)
     assert(info1.host === info2.host)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org