You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "danny0405 (via GitHub)" <gi...@apache.org> on 2023/04/30 03:29:45 UTC
[GitHub] [hudi] danny0405 commented on a diff in pull request #8604: [HUDI-6151] Rollback previously applied commits to MDT when operations are retried.
danny0405 commented on code in PR #8604:
URL: https://github.com/apache/hudi/pull/8604#discussion_r1181157786
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/metadata/SparkHoodieBackedTableMetadataWriter.java:
##########
@@ -161,27 +161,28 @@ protected void commit(String instantTime, Map<MetadataPartitionType, HoodieData<
if (!metadataMetaClient.getActiveTimeline().containsInstant(instantTime)) {
// if this is a new commit being applied to metadata for the first time
- writeClient.startCommitWithTime(instantTime);
+ LOG.info("New commit at " + instantTime + " being applied to MDT");
} else {
Review Comment:
to MDT -> to MDT.
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/metadata/SparkHoodieBackedTableMetadataWriter.java:
##########
@@ -161,27 +161,28 @@ protected void commit(String instantTime, Map<MetadataPartitionType, HoodieData<
if (!metadataMetaClient.getActiveTimeline().containsInstant(instantTime)) {
// if this is a new commit being applied to metadata for the first time
- writeClient.startCommitWithTime(instantTime);
+ LOG.info("New commit at " + instantTime + " being applied to MDT");
} else {
+ // this code path refers to a re-attempted commit that:
+ // 1. got committed to metadata table, but failed in datatable.
+ // 2. failed while commiting to metadata table
+ // for eg, lets say compaction c1 on 1st attempt succeeded in metadata table and failed before committing to datatable.
+ // when retried again, data table will first rollback pending compaction. these will be applied to metadata table, but all changes
Review Comment:
for eg -> for e.g
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/metadata/SparkHoodieBackedTableMetadataWriter.java:
##########
@@ -161,27 +161,28 @@ protected void commit(String instantTime, Map<MetadataPartitionType, HoodieData<
if (!metadataMetaClient.getActiveTimeline().containsInstant(instantTime)) {
// if this is a new commit being applied to metadata for the first time
- writeClient.startCommitWithTime(instantTime);
+ LOG.info("New commit at " + instantTime + " being applied to MDT");
} else {
+ // this code path refers to a re-attempted commit that:
+ // 1. got committed to metadata table, but failed in datatable.
+ // 2. failed while commiting to metadata table
+ // for eg, lets say compaction c1 on 1st attempt succeeded in metadata table and failed before committing to datatable.
+ // when retried again, data table will first rollback pending compaction. these will be applied to metadata table, but all changes
+ // are upserts to metadata table and so only a new delta commit will be created.
+ // once rollback is complete in datatable, compaction will be retried again, which will eventually hit this code block where the respective commit is
+ // already part of completed commit. So, we have to manually rollback the completed instant and proceed.
Option<HoodieInstant> alreadyCompletedInstant = metadataMetaClient.getActiveTimeline().filterCompletedInstants().filter(entry -> entry.getTimestamp().equals(instantTime)).lastInstant();
- if (alreadyCompletedInstant.isPresent()) {
- // this code path refers to a re-attempted commit that got committed to metadata table, but failed in datatable.
- // for eg, lets say compaction c1 on 1st attempt succeeded in metadata table and failed before committing to datatable.
- // when retried again, data table will first rollback pending compaction. these will be applied to metadata table, but all changes
- // are upserts to metadata table and so only a new delta commit will be created.
- // once rollback is complete, compaction will be retried again, which will eventually hit this code block where the respective commit is
- // already part of completed commit. So, we have to manually remove the completed instant and proceed.
- // and it is for the same reason we enabled withAllowMultiWriteOnSameInstant for metadata table.
- HoodieActiveTimeline.deleteInstantFile(metadataMetaClient.getFs(), metadataMetaClient.getMetaPath(), alreadyCompletedInstant.get());
- metadataMetaClient.reloadActiveTimeline();
+ LOG.info(String.format("%s completed commit at %s being applied to metadata table",
+ alreadyCompletedInstant.isPresent() ? "Already" : "Partially", instantTime));
Review Comment:
applied to metadata table -> applied to metadata table.
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/metadata/SparkHoodieBackedTableMetadataWriter.java:
##########
@@ -161,27 +161,28 @@ protected void commit(String instantTime, Map<MetadataPartitionType, HoodieData<
if (!metadataMetaClient.getActiveTimeline().containsInstant(instantTime)) {
// if this is a new commit being applied to metadata for the first time
- writeClient.startCommitWithTime(instantTime);
+ LOG.info("New commit at " + instantTime + " being applied to MDT");
} else {
+ // this code path refers to a re-attempted commit that:
+ // 1. got committed to metadata table, but failed in datatable.
+ // 2. failed while commiting to metadata table
+ // for eg, lets say compaction c1 on 1st attempt succeeded in metadata table and failed before committing to datatable.
+ // when retried again, data table will first rollback pending compaction. these will be applied to metadata table, but all changes
Review Comment:
lets say -> let's say
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org