You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/07 21:20:35 UTC

[GitHub] [beam] chamikaramj commented on a diff in pull request #21739: Fix for increased FAILED_PRECONDITION errors in BQ Read API.

chamikaramj commented on code in PR #21739:
URL: https://github.com/apache/beam/pull/21739#discussion_r891719608


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java:
##########
@@ -355,6 +356,7 @@ public synchronized BigQueryStorageStreamSource<T> getCurrentSource() {
                       .build(),
                   source.readSession.getTable());
           newResponseIterator = newResponseStream.iterator();
+          newResponseIterator.hasNext();

Review Comment:
   Probably let's add a log line here describing why this call is important. For someone who doesn't understand the details regarding the BQ API, it's just an ignored hasNext call which might be removed in the future cleanups.
   
   Also, does this points to an issue with the API ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org