[jira] [Commented] (AMQ-6036) Too trivial check in SubQueueSelectorCacheBroker.hasWildcards

["Christopher L. Shannon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-6036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130382#comment-15130382 ] 

Christopher L. Shannon commented on AMQ-6036:
---------------------------------------------

Sorry for the delay, the patch looks pretty good to me.  The only thing missing is the apache license headers.  Can you add those to your new files and also rebase against master?

> Too trivial check in SubQueueSelectorCacheBroker.hasWildcards
> -------------------------------------------------------------
>
>                 Key: AMQ-6036
>                 URL: https://issues.apache.org/jira/browse/AMQ-6036
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.12.1
>            Reporter: Patrik Dudits
>            Assignee: Christopher L. Shannon
>
> VirtualSelectorCache plugin cannot be reliably used when message selectors use e. g. literals with underscore like {{notificationType = 'NOTIFY_DELETE'}}.
> Full evaluation would need to walk the parsed selector, however the method should at least check for presence of {{LIKE}} case-insensitevely to return less false positives.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)