[GitHub] [cordova-android] raphinesse opened a new pull request #713: Do not explicitly require modules from project directory

[GitBox <gi...@apache.org>]

raphinesse opened a new pull request #713:  Do not explicitly require modules from project directory
URL: https://github.com/apache/cordova-android/pull/713
 
 
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Before this change, the following would fail if `cordova-android` or one of its dependencies are not resolvable from `dir`:
   ```js
   require('cordova-android').createPlatform(dir, configParser, null, events)
   ```
   
   This happens for example if you want to setup a platform-centered App from scratch. In my case I needed to do that during `plugman` test setups in `cordova-lib`.
   
   The problem is, that during project creation `cordova-android` requires some of the modules that have been checked-out to the project directory instead of the ones relative to the running modules (looking at the actual changes will probably clarify what I'm trying to say here).
   
   ### Description
   Instead of switching to the checked-out modules in the created platform-project, we simply use the identical modules relative to the active ones.
   
   
   ### Testing
   Ran the automated test suite. Ran tests in `cordova-lib` that use `cordova-android` using this updated version.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org