[GitHub] [storm] HeartSaVioR commented on a change in pull request #2970: STORM-3354: Fix Nimbus not reentering leadership election in some cas…

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #2970: STORM-3354: Fix Nimbus not reentering leadership election in some cas…
URL: https://github.com/apache/storm/pull/2970#discussion_r269974721
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/nimbus/LeaderListenerCallback.java
 ##########
 @@ -60,31 +62,35 @@
     private final TopoCache tc;
     private final IStormClusterState clusterState;
     private final CuratorFramework zk;
-    private final LeaderLatch leaderLatch;
+    private final ILeaderElector leaderElector;
     private final Map conf;
     private final List<ACL> acls;
+    private final int requeueDelayMs;
 
     /**
      * Constructor for {@LeaderListenerCallback}.
      * @param conf config
      * @param zk zookeeper CuratorFramework client
-     * @param leaderLatch LeaderLatch
+     * @param leaderElector Leader elector
      * @param blobStore BlobStore
      * @param tc TopoCache
      * @param clusterState IStormClusterState
      * @param acls zookeeper acls
      */
-    public LeaderListenerCallback(Map conf, CuratorFramework zk, LeaderLatch leaderLatch, BlobStore blobStore,
+    public LeaderListenerCallback(Map conf, CuratorFramework zk, BlobStore blobStore, ILeaderElector leaderElector,
 
 Review comment:
   nit: param orders changed while it's not reflected to javadoc

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services