You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/09/08 01:41:25 UTC

[kudu-CR] [jepsen] set default admin operation timeout to 5 minutes 

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11405


Change subject: [jepsen] set default admin operation timeout to 5 minutes
......................................................................

[jepsen] set default admin operation timeout to 5 minutes

Increased the default admin operation timeout for the Kudu client
used in Jepsen tests up to 5 minutes.  That's to work around slow DNS
resolutions (sometimes up to 30 seconds) that happen intermittently
while running the tests at VMs provisioned in GCE.

Change-Id: Iaa9ade5cf38b4f3247749fa33bd40ada9616f21f
---
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/client.clj
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/11405/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11405
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa9ade5cf38b4f3247749fa33bd40ada9616f21f
Gerrit-Change-Number: 11405
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [jepsen] set default admin operation timeout to 2 minutes

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11405 )

Change subject: [jepsen] set default admin operation timeout to 2 minutes
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11405
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa9ade5cf38b4f3247749fa33bd40ada9616f21f
Gerrit-Change-Number: 11405
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 10 Sep 2018 21:54:48 +0000
Gerrit-HasComments: No

[kudu-CR] [jepsen] set default admin operation timeout to 2 minutes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11405 )

Change subject: [jepsen] set default admin operation timeout to 2 minutes
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11405/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11405/2//COMMIT_MSG@11
PS2, Line 11: 30 seconds
> Sorry for the confusion. I mean why not increase it to 4 mins, 6 mins, or a
OK, after some offline discussion with Hao we decided to put 2 minutes as the value for the default admin operation timeout.



-- 
To view, visit http://gerrit.cloudera.org:8080/11405
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa9ade5cf38b4f3247749fa33bd40ada9616f21f
Gerrit-Change-Number: 11405
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 10 Sep 2018 21:56:23 +0000
Gerrit-HasComments: Yes

[kudu-CR] [jepsen] set default admin operation timeout to 2 minutes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11405 )

Change subject: [jepsen] set default admin operation timeout to 2 minutes
......................................................................

[jepsen] set default admin operation timeout to 2 minutes

Increased the default admin operation timeout for the Kudu client
used in Jepsen tests up to 2 minutes.  That's to work around slow DNS
resolutions (sometimes up to 30 seconds) that happen intermittently
while running the tests at VMs provisioned in GCE.

Change-Id: Iaa9ade5cf38b4f3247749fa33bd40ada9616f21f
Reviewed-on: http://gerrit.cloudera.org:8080/11405
Reviewed-by: Hao Hao <ha...@cloudera.com>
Tested-by: Kudu Jenkins
---
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/client.clj
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Hao Hao: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11405
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa9ade5cf38b4f3247749fa33bd40ada9616f21f
Gerrit-Change-Number: 11405
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [jepsen] set default admin operation timeout to 5 minutes

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11405 )

Change subject: [jepsen] set default admin operation timeout to 5 minutes
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11405/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11405/2//COMMIT_MSG@11
PS2, Line 11: 30 seconds
Is it necessary to increase the timeout to 5 mins if the slow DNS resolution can only take up tp 30 seconds?



-- 
To view, visit http://gerrit.cloudera.org:8080/11405
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa9ade5cf38b4f3247749fa33bd40ada9616f21f
Gerrit-Change-Number: 11405
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 10 Sep 2018 21:12:03 +0000
Gerrit-HasComments: Yes

[kudu-CR] [jepsen] set default admin operation timeout to 5 minutes

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11405 )

Change subject: [jepsen] set default admin operation timeout to 5 minutes
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11405/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11405/2//COMMIT_MSG@11
PS2, Line 11: 30 seconds
> Yep, that's what I did -- increased the default admin operation timeout to 
Sorry for the confusion. I mean why not increase it to 4 mins, 6 mins, or anything above 30 seconds?



-- 
To view, visit http://gerrit.cloudera.org:8080/11405
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa9ade5cf38b4f3247749fa33bd40ada9616f21f
Gerrit-Change-Number: 11405
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 10 Sep 2018 21:31:36 +0000
Gerrit-HasComments: Yes

[kudu-CR] [jepsen] set default admin operation timeout to 2 minutes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11405

to look at the new patch set (#3).

Change subject: [jepsen] set default admin operation timeout to 2 minutes
......................................................................

[jepsen] set default admin operation timeout to 2 minutes

Increased the default admin operation timeout for the Kudu client
used in Jepsen tests up to 2 minutes.  That's to work around slow DNS
resolutions (sometimes up to 30 seconds) that happen intermittently
while running the tests at VMs provisioned in GCE.

Change-Id: Iaa9ade5cf38b4f3247749fa33bd40ada9616f21f
---
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/client.clj
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/11405/3
-- 
To view, visit http://gerrit.cloudera.org:8080/11405
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa9ade5cf38b4f3247749fa33bd40ada9616f21f
Gerrit-Change-Number: 11405
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [jepsen] set default admin operation timeout to 5 minutes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11405

to look at the new patch set (#2).

Change subject: [jepsen] set default admin operation timeout to 5 minutes
......................................................................

[jepsen] set default admin operation timeout to 5 minutes

Increased the default admin operation timeout for the Kudu client
used in Jepsen tests up to 5 minutes.  That's to work around slow DNS
resolutions (sometimes up to 30 seconds) that happen intermittently
while running the tests at VMs provisioned in GCE.

Change-Id: Iaa9ade5cf38b4f3247749fa33bd40ada9616f21f
---
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/client.clj
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/11405/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11405
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa9ade5cf38b4f3247749fa33bd40ada9616f21f
Gerrit-Change-Number: 11405
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [jepsen] set default admin operation timeout to 5 minutes

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11405 )

Change subject: [jepsen] set default admin operation timeout to 5 minutes
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11405/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11405/2//COMMIT_MSG@11
PS2, Line 11: 30 seconds
> Is it necessary to increase the timeout to 5 mins if the slow DNS resolutio
Yep, that's what I did -- increased the default admin operation timeout to 5 minutes, so creation of a table will not timeout if DNS resolution takes that long.

Or you mean we should update some other timeouts as well?



-- 
To view, visit http://gerrit.cloudera.org:8080/11405
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa9ade5cf38b4f3247749fa33bd40ada9616f21f
Gerrit-Change-Number: 11405
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 10 Sep 2018 21:19:59 +0000
Gerrit-HasComments: Yes