[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7212: arch/armv[7|8]-m: Implement up_invalidate_icache

[GitBox <gi...@apache.org>]

acassis commented on code in PR #7212:
URL: https://github.com/apache/incubator-nuttx/pull/7212#discussion_r983523432


##########
arch/arm/src/armv8-m/arm_cache.c:
##########
@@ -176,6 +176,78 @@ void up_disable_icache(void)
 }
 #endif
 
+/****************************************************************************
+ * Name: up_invalidate_icache
+ *
+ * Description:
+ *   Invalidate the instruction cache within the specified region.
+ *
+ * Input Parameters:
+ *   start - virtual start address of region
+ *   end   - virtual end address of region + 1
+ *
+ * Returned Value:
+ *   None
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_ARMV8M_ICACHE
+void up_invalidate_icache(uintptr_t start, uintptr_t end)

Review Comment:
   @xiaoxiang781216 since the up_invalidate_icache() is basically the same for armv7-m and armv8-m, shouldn't it be possible to use a common definition for both?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org