You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by ashishawasthi <gi...@git.apache.org> on 2016/05/09 10:11:46 UTC

[GitHub] spark pull request: [SPARK-15223] [DOCS] [MINOR] Fixed scaladoc ja...

GitHub user ashishawasthi opened a pull request:

    https://github.com/apache/spark/pull/13004

    [SPARK-15223] [DOCS] [MINOR] Fixed scaladoc java example syntax in DataSet @rxin

    ## What changes were proposed in this pull request?
    Fixed scaladoc java example syntax in DataSet.scala
    
    ## How was this patch tested?
    No new tests required as this is a doc example change
    Existing tests passed (using ./dev/run-tests)
    
    p.s. I didn't create a new JIRA as the [guidelines](https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark#ContributingtoSpark-JIRA) say, "trivial changes, where the what should change is virtually the same as the how it should change do not require a JIRA"

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ashishawasthi/spark SPARK-13826-DOCS-scaladoc-java-example-syntax

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13004.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13004
    
----
commit 59ff9accb6f84dcbaeae5e92c291c13e9135a7af
Author: Ashish <as...@gmail.com>
Date:   2016-05-09T09:59:15Z

    [SPARK-15223] [DOCS] fix scaladoc java example syntax in DataSet

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-15223] [DOCS] [MINOR] Fixed scaladoc ja...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the pull request:

    https://github.com/apache/spark/pull/13004#issuecomment-217837856
  
    @ashishawasthi Then, I think you can take out `[SPARK-15223]` which I guess it is not related. Also, It would be nicer if the title does not have `@rxin` at the end. Lastly, `p.s.` might better be left in comments because it might not related with the PR description itself.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org