You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/05 16:05:04 UTC
[jira] [Commented] (BEAM-2179) Archetype generate-sources.sh should
delete old files
[ https://issues.apache.org/jira/browse/BEAM-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998506#comment-15998506 ]
ASF GitHub Bot commented on BEAM-2179:
--------------------------------------
GitHub user jbonofre opened a pull request:
https://github.com/apache/beam/pull/2913
[BEAM-2179] Archetype generate-sources.sh cleanup the existing sources before rsync
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [X] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [X] Make sure tests pass via `mvn clean verify`.
- [X] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [X] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbonofre/beam BEAM-2179-ARCHETYPES-GENERATE-SOURCES
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2913.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2913
----
----
> Archetype generate-sources.sh should delete old files
> -----------------------------------------------------
>
> Key: BEAM-2179
> URL: https://issues.apache.org/jira/browse/BEAM-2179
> Project: Beam
> Issue Type: Bug
> Components: project-management
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
>
> Examples archetypes use {{generate-sources.sh}} to copy the sources from examples modules into the archetype resources. However, it's a simple copy and doesn't remove previously copied files (it's just an overwrite).
> It means that if we remove a file in examples module, it's not updated in the archetypes (the file is still present).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)