You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/07/26 16:53:33 UTC
[GitHub] [cordova-plugin-wkwebview-engine] dpogue commented on issue #108:
Content dimensions incorrect at startup on iPhone X
dpogue commented on issue #108: Content dimensions incorrect at startup on iPhone X
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/108#issuecomment-515525257
1. What is the value of the `viewport` meta tag?
2. Is the body's first child element using `height: 100%` or `height: 100vh`?
The fix in #45 is not a fix because it takes control of the webview behaviour away from the app developer and unilaterally enforces a decision about the handling of safe areas on all Cordova apps. That change is already known to break several existing apps that are handling safe areas properly, which is why it was reverted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org