You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by adeneche <gi...@git.apache.org> on 2016/01/22 00:32:36 UTC
[GitHub] drill pull request: Drill 4261: add support for RANGE BETWEEN UNBO...
GitHub user adeneche opened a pull request:
https://github.com/apache/drill/pull/334
Drill 4261: add support for RANGE BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adeneche/incubator-drill DRILL-4261
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/334.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #334
----
commit c5c2eda7997c5dfb9335b02a25272c0e6ddc48b1
Author: adeneche <ad...@gmail.com>
Date: 2016-01-19T21:33:22Z
passing WindowPOP to window functions and framers
commit 82395aefce54eb89eb98fd7420f4fc6a4b369be1
Author: adeneche <ad...@gmail.com>
Date: 2016-01-19T21:34:59Z
WindowPOP.Bound to describe FRAME bounds
commit 93333e1568f54d51894ae5d8740b7c0e8aa9067c
Author: adeneche <ad...@gmail.com>
Date: 2016-01-20T19:41:26Z
DRILL-4261: Add support for RANGE BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: Drill 4261: add support for RANGE BETWEEN UNBO...
Posted by adeneche <gi...@git.apache.org>.
Github user adeneche commented on the pull request:
https://github.com/apache/drill/pull/334#issuecomment-173995199
regression tests passed twice
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: Drill 4261: add support for RANGE BETWEEN UNBO...
Posted by adeneche <gi...@git.apache.org>.
Github user adeneche closed the pull request at:
https://github.com/apache/drill/pull/334
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: Drill 4261: add support for RANGE BETWEEN UNBO...
Posted by adeneche <gi...@git.apache.org>.
Github user adeneche commented on the pull request:
https://github.com/apache/drill/pull/334#issuecomment-173749885
running regression tests now.
@amansinha100 can you please review ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: Drill 4261: add support for RANGE BETWEEN UNBO...
Posted by jaltekruse <gi...@git.apache.org>.
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/334#discussion_r50482911
--- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java ---
@@ -106,6 +106,16 @@ public void testMultipleFramers() throws Exception {
);
}
+ @Test
+ public void testUnboundedFollowing() throws Exception {
+ testBuilder()
+ .sqlQuery(String.format(getFile("window/q3.sql"), TEST_RES_PATH))
+ .ordered()
+ .sqlBaselineQuery(String.format(getFile("window/q3.sql"), TEST_RES_PATH))
--- End diff --
Is this supposed to be q4.sql?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: Drill 4261: add support for RANGE BETWEEN UNBO...
Posted by adeneche <gi...@git.apache.org>.
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/334#discussion_r50492010
--- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java ---
@@ -106,6 +106,16 @@ public void testMultipleFramers() throws Exception {
);
}
+ @Test
+ public void testUnboundedFollowing() throws Exception {
+ testBuilder()
+ .sqlQuery(String.format(getFile("window/q3.sql"), TEST_RES_PATH))
+ .ordered()
+ .sqlBaselineQuery(String.format(getFile("window/q3.sql"), TEST_RES_PATH))
--- End diff --
Yep
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---