You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/04/24 08:38:07 UTC
[GitHub] [incubator-eventmesh] liangyuanpeng opened a new pull request #313: [ISSUE #310] add github action for check license
liangyuanpeng opened a new pull request #313:
URL: https://github.com/apache/incubator-eventmesh/pull/313
fixed #301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] SteveYurongSu edited a comment on pull request #313: [ISSUE #310] add github action for check license
Posted by GitBox <gi...@apache.org>.
SteveYurongSu edited a comment on pull request #313:
URL: https://github.com/apache/incubator-eventmesh/pull/313#issuecomment-849292735
Hi @liangyuanpeng , will you continue to work on this PR?
If you are no longer working on this PR, I would like to continue to maintain your existing work (by pulling your PR) and submit a new PR (then you will be a co-author), thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] liangyuanpeng edited a comment on pull request #313: [ISSUE #310] add github action for check license
Posted by GitBox <gi...@apache.org>.
liangyuanpeng edited a comment on pull request #313:
URL: https://github.com/apache/incubator-eventmesh/pull/313#issuecomment-851973577
So, This PR have any problem? I just waiting for review and got nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] kezhenxu94 commented on a change in pull request #313: [ISSUE #310] add github action for check license
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #313:
URL: https://github.com/apache/incubator-eventmesh/pull/313#discussion_r619660386
##########
File path: .github/workflows/check-license.yml
##########
@@ -0,0 +1,23 @@
+ This workflow will build a Java project with Maven
Review comment:
This line is wrong in syntax. Should start with #
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] SteveYurongSu commented on pull request #313: [ISSUE #310] add github action for check license
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on pull request #313:
URL: https://github.com/apache/incubator-eventmesh/pull/313#issuecomment-849292735
Hi, will you continue to work on this PR?
If you are no longer working on this PR, I would like to continue to maintain your existing work (by pulling your PR) and submit a new PR (then you will be a co-author), thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] liangyuanpeng commented on a change in pull request #313: [ISSUE #310] add github action for check license
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on a change in pull request #313:
URL: https://github.com/apache/incubator-eventmesh/pull/313#discussion_r619675006
##########
File path: .github/workflows/check-license.yml
##########
@@ -0,0 +1,23 @@
+ This workflow will build a Java project with Maven
Review comment:
Thanks for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] kezhenxu94 commented on a change in pull request #313: [ISSUE #310] add github action for check license
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #313:
URL: https://github.com/apache/incubator-eventmesh/pull/313#discussion_r619660386
##########
File path: .github/workflows/check-license.yml
##########
@@ -0,0 +1,23 @@
+ This workflow will build a Java project with Maven
Review comment:
This line is wrong in syntax. Should start with #
```suggestion
# This workflow will build a Java project with Maven
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen merged pull request #313: [ISSUE #310] add github action for check license
Posted by GitBox <gi...@apache.org>.
qqeasonchen merged pull request #313:
URL: https://github.com/apache/incubator-eventmesh/pull/313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] liangyuanpeng commented on a change in pull request #313: [ISSUE #310] add github action for check license
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on a change in pull request #313:
URL: https://github.com/apache/incubator-eventmesh/pull/313#discussion_r619675006
##########
File path: .github/workflows/check-license.yml
##########
@@ -0,0 +1,23 @@
+ This workflow will build a Java project with Maven
Review comment:
Thanks for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] kezhenxu94 commented on a change in pull request #313: [ISSUE #310] add github action for check license
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #313:
URL: https://github.com/apache/incubator-eventmesh/pull/313#discussion_r619660386
##########
File path: .github/workflows/check-license.yml
##########
@@ -0,0 +1,23 @@
+ This workflow will build a Java project with Maven
Review comment:
This line is wrong in syntax. Should start with #
##########
File path: .github/workflows/check-license.yml
##########
@@ -0,0 +1,23 @@
+ This workflow will build a Java project with Maven
Review comment:
This line is wrong in syntax. Should start with #
```suggestion
# This workflow will build a Java project with Maven
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #313: [ISSUE #310] add github action for check license
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on pull request #313:
URL: https://github.com/apache/incubator-eventmesh/pull/313#issuecomment-851984178
> Hi @liangyuanpeng , will you continue to work on this PR?
>
> If you are no longer working on this PR, I would like to continue to maintain your existing work (by pulling your PR) and submit a new PR (then you will be a co-author), thanks!
@liangyuanpeng I thought @SteveYurongSu will solve the probmen in #377 , my concern is still exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] liangyuanpeng commented on pull request #313: [ISSUE #310] add github action for check license
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on pull request #313:
URL: https://github.com/apache/incubator-eventmesh/pull/313#issuecomment-851973577
So, This PR have any problem? I juse waiting for review and got nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org