You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Jeremias Maerki <de...@greenmail.ch> on 2004/04/01 23:21:24 UTC
Re: DO NOT REPLY [Bug 28044] - Patch, Avalon Logging to Commons Logging Conversion.
I got home late today, so I didn't manage to finish everything. I will
do that tomorrow morning.
Todos:
- Figure out how best to configure the SimpleLog when using static
loggers in command line apps.
- Fix examples in examples/embedding
- Fix tests
- Update Gump descriptor to include the new dependency on JCL. We're
lucky that we don't get nagged as Batik has a compilation problem ATM.
On 31.03.2004 08:34:13 Jeremias wrote:
> I'm busy today but I'll try to do the whole thing for the PDF and library code
> on Thursday evening (CET).
Jeremias Maerki
Re: DO NOT REPLY [Bug 28044] - Patch, Avalon Logging to Commons Logging Conversion.
Posted by Jeremias Maerki <de...@greenmail.ch>.
On 02.04.2004 03:47:16 Glen Mazza wrote:
>
> --- Jeremias Maerki <de...@greenmail.ch> wrote:
> > I got home late today, so I didn't manage to finish
> > everything. I will
> > do that tomorrow morning.
> >
> > Todos:
Actually, these todos were rather targeted at myself but I'm glad you
jumped in. THANKS!
> > - Figure out how best to configure the SimpleLog
> > when using static
> > loggers in command line apps.
>
> I'll let you start the cogitation here. ;)
See my other post.
> > - Fix examples in examples/embedding
>
> Just done, as well as updated some of the
> documentation. Also tested them. Feel free of course
> to make adjustments as you wish.
Look fine, thanks!
> > - Fix tests
>
> Done--only one file (BasicDriverTestSuite) needed
> changing. BTW, the subsequent test fails as follows
> for this file (the other test files are all OK)--but
> it appears unrelated to the logger switch (it may be
> something with my machine):
>
> Testcase: testFO2PDFWithConstructorSetupTestcase:
> testFO2PDFWithInputSource took 0 sec
> Caused an ERROR
> loader constraints violated when linking
> org/xml/sax/XMLReader class
> java.lang.LinkageError: loader constraints violated
> when linking org/xml/sax/XMLReader class
> at
> org.apache.xerces.jaxp.SAXParserFactoryImpl.newSAXParser(Unknown
> Source)
> at
> org.apache.fop.apps.FOFileHandler.createParser(FOFileHandler.java:91)
> at org.apache.fop.apps.Driver.run(Driver.java:655)
> at
> org.apache.fop.BasicDriverTestCase.testFO2PDFWithInputSource(BasicDriverTestCase.java:89)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> ....
>
> (over and over again for each test within this file)
Have you got two different versions of Xerces or JAXP in your classpath
maybe?
I've got another one:
org.w3c.dom.DOMException: NAMESPACE_ERR: An attempt is made to create or
change an object in a way which is incorrect with regard to namespaces.
at org.apache.xerces.dom.CoreDocumentImpl.checkDOMNSErr(Unknown Source)
I haven't taken the time, though, to track it down, yet.
> > - Update Gump descriptor to include the new
> > dependency on JCL. We're
> > lucky that we don't get nagged as Batik has a
> > compilation problem ATM.
> >
>
> I don't know where this file is.
Right here:
http://cvs.apache.org/viewcvs.cgi/gump/project/xml-fop.xml
http://cvs.apache.org/viewcvs.cgi/gump/project/xml-fop-maintenance.xml
I'll change them in a few minutes.
Jeremias Maerki
Re: DO NOT REPLY [Bug 28044] - Patch, Avalon Logging to Commons
Logging Conversion.
Posted by Glen Mazza <gr...@yahoo.com>.
Jeremias Maerki schrieb:
>Yes, Axis uses JCL just as I wanted. Concerning the discovery things,
>they are using Commons Discovery [1]. I'm not sure myself what the
>intent/benefit is behind it but I'm pretty sure we don't have to do the
>same. For the moment, I think the current approach is quite satisfying.
>Anyone else want to comment?
>
>
>
Sounds good--let's not make things more complex unless we have a good
reason why.
Glen
>[1] http://jakarta.apache.org/commons/discovery/
>
>
>
Re: DO NOT REPLY [Bug 28044] - Patch, Avalon Logging to Commons Logging Conversion.
Posted by Jeremias Maerki <de...@greenmail.ch>.
Yes, Axis uses JCL just as I wanted. Concerning the discovery things,
they are using Commons Discovery [1]. I'm not sure myself what the
intent/benefit is behind it but I'm pretty sure we don't have to do the
same. For the moment, I think the current approach is quite satisfying.
Anyone else want to comment?
[1] http://jakarta.apache.org/commons/discovery/
On 02.04.2004 04:57:45 Glen Mazza wrote:
> Actually, what the Axis team did in their code may be
> a good example for us.
>
> They created their own LogFactory class [1], and in
> 167 files, such as here [2] and [3], they activate
> that LogFactory class with the name of the class where
> the logging is occur.
>
> It appears that they created their own LogFactory to
> centralize in one place the exact type of logger that
> will be created. Also, they're doing something
> security- and "singleton discovery"-related, I'm
> unsure of its relevance for us, however--Axis has
> requirements quite different from us, of course.
Jeremias Maerki
Re: DO NOT REPLY [Bug 28044] - Patch, Avalon Logging to Commons Logging Conversion.
Posted by Glen Mazza <gr...@yahoo.com>.
--- Glen Mazza <gr...@yahoo.com> wrote:
>
> --- Jeremias Maerki <de...@greenmail.ch>
> wrote:
> > I got home late today, so I didn't manage to
> finish
> > everything. I will
> > do that tomorrow morning.
> >
> > Todos:
> > - Figure out how best to configure the SimpleLog
> > when using static
> > loggers in command line apps.
>
> I'll let you start the cogitation here. ;)
>
>
Actually, what the Axis team did in their code may be
a good example for us.
They created their own LogFactory class [1], and in
167 files, such as here [2] and [3], they activate
that LogFactory class with the name of the class where
the logging is occur.
It appears that they created their own LogFactory to
centralize in one place the exact type of logger that
will be created. Also, they're doing something
security- and "singleton discovery"-related, I'm
unsure of its relevance for us, however--Axis has
requirements quite different from us, of course.
[1]
http://cvs.apache.org/viewcvs.cgi/ws-axis/java/src/org/apache/axis/components/logger/LogFactory.java?rev=1.8&view=auto
[2] (top of class definition)
http://cvs.apache.org/viewcvs.cgi/ws-axis/java/src/org/apache/axis/encoding/DeserializerImpl.java?annotate=1.39
[3] (top of class definition)
http://cvs.apache.org/viewcvs.cgi/ws-axis/java/src/org/apache/axis/components/threadpool/ThreadPool.java?rev=1.5&view=auto
Glen
Re: DO NOT REPLY [Bug 28044] - Patch, Avalon Logging to Commons Logging Conversion.
Posted by Glen Mazza <gr...@yahoo.com>.
--- Jeremias Maerki <de...@greenmail.ch> wrote:
> I got home late today, so I didn't manage to finish
> everything. I will
> do that tomorrow morning.
>
> Todos:
> - Figure out how best to configure the SimpleLog
> when using static
> loggers in command line apps.
I'll let you start the cogitation here. ;)
> - Fix examples in examples/embedding
Just done, as well as updated some of the
documentation. Also tested them. Feel free of course
to make adjustments as you wish.
> - Fix tests
Done--only one file (BasicDriverTestSuite) needed
changing. BTW, the subsequent test fails as follows
for this file (the other test files are all OK)--but
it appears unrelated to the logger switch (it may be
something with my machine):
Testcase: testFO2PDFWithConstructorSetupTestcase:
testFO2PDFWithInputSource took 0 sec
Caused an ERROR
loader constraints violated when linking
org/xml/sax/XMLReader class
java.lang.LinkageError: loader constraints violated
when linking org/xml/sax/XMLReader class
at
org.apache.xerces.jaxp.SAXParserFactoryImpl.newSAXParser(Unknown
Source)
at
org.apache.fop.apps.FOFileHandler.createParser(FOFileHandler.java:91)
at org.apache.fop.apps.Driver.run(Driver.java:655)
at
org.apache.fop.BasicDriverTestCase.testFO2PDFWithInputSource(BasicDriverTestCase.java:89)
at
sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
....
(over and over again for each test within this file)
> - Update Gump descriptor to include the new
> dependency on JCL. We're
> lucky that we don't get nagged as Batik has a
> compilation problem ATM.
>
I don't know where this file is.
> On 31.03.2004 08:34:13 Jeremias wrote:
> > I'm busy today but I'll try to do the whole thing
> for the PDF and library code
> > on Thursday evening (CET).
>
>
> Jeremias Maerki
>
Thanks for the help.
Glen