[GitHub] [rocketmq] ahuazhu edited a comment on issue #1346: remove no need code while init Hashmap

[GitBox <gi...@apache.org>]

ahuazhu edited a comment on issue #1346: remove no need code while init Hashmap
URL: https://github.com/apache/rocketmq/pull/1346#issuecomment-515929102
 
 
   > Diamond types are not supported at jdk1.6
   
   RocketMQ required jdk1.8  in the root pom.xml.
   
   ```
           <maven.compiler.source>1.8</maven.compiler.source>
           <maven.compiler.target>1.8</maven.compiler.target>
   ```
   
   Furthermore, how about declare the type of field `configTable`  as `Map`?
   
   Change 
   ```
   private final HashMap<String/* Namespace */, HashMap<String/* Key */, String/* Value */>> configTable =	    private final HashMap<String/* Namespace */, HashMap<String/* Key */, String/* Value */>> configTable =
           new HashMap<String, HashMap<String, String>>()
   ```
   
   To 
   
   ```
   private final Map<String/* Namespace */, HashMap<String/* Key */, String/* Value */>> configTable =
           new HashMap<>();
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services