[jira] [Commented] (GEODE-8692) ArrayIndexOutOfBoundsException may be thrown in RegionAdvisor.processProfilesQueuedDuringInitialization

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228759#comment-17228759 ] 

ASF GitHub Bot commented on GEODE-8692:
---------------------------------------

sabbey37 opened a new pull request #5722:
URL: https://github.com/apache/geode/pull/5722


   If `RegionAdvisor.buckets == null` at the time the value of `serials` is generated, an `ArrayIndexOutOfBoundsException` may be thrown in `RegionAdvisor.processProfilesQueuedDuringInitialization` if buckets have been initialized at that point.
   
   Code where `ArrayIndexOutOfBoundsException` might be thrown in `RegionAdvisor.processProfilesQueuedDuringInitialization()`:
   
   ```
   for (int i = 0; i < buckets.length; i++) {
     BucketAdvisor ba = buckets[i].getBucketAdvisor();
     int serial = qbp.serials[i]; <<< Exception thrown here
     if (serial != ILLEGAL_SERIAL) {
       ba.removeIdWithSerial(qbp.memberId, serial, qbp.destroyed);
     }
   }
   ```
   We ultimately decided that if the buckets were not created at the time the value of `serials` is generated, there is no need to worry about their profiles getting deleted later.  To avoid the `ArrayIndexOutOfBoundsException`, `getBucketSerials()` was modified to return an array of `ILLEGAL_SERIAL` values if the buckets had not been created yet.
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [x] Have you written or updated unit tests to verify your changes?
   
   - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> ArrayIndexOutOfBoundsException may be thrown in RegionAdvisor.processProfilesQueuedDuringInitialization
> -------------------------------------------------------------------------------------------------------
>
>                 Key: GEODE-8692
>                 URL: https://issues.apache.org/jira/browse/GEODE-8692
>             Project: Geode
>          Issue Type: Bug
>            Reporter: Sarah Abbey
>            Assignee: Sarah Abbey
>            Priority: Minor
>
> If {{RegionAdvisor.buckets == null}} at the time the value of {{serials}} is generated, an {{ArrayIndexOutOfBoundsException}} may be thrown in {{RegionAdvisor.processProfilesQueuedDuringInitialization}} if buckets have been initialized at that point.
> Code where {{ArrayIndexOutOfBoundsException}} might be thrown in {{RegionAdvisor.processProfilesQueuedDuringInitialization():}}
> {code:java}
> for (int i = 0; i < buckets.length; i++) {
>   BucketAdvisor ba = buckets[i].getBucketAdvisor();
>   int serial = qbp.serials[i]; <<< Exception thrown here
>   if (serial != ILLEGAL_SERIAL) {
>     ba.removeIdWithSerial(qbp.memberId, serial, qbp.destroyed);
>   }
> }
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)