[jira] [Commented] (FLINK-5014) RocksDBStateBackend misses good toString

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639342#comment-15639342 ] 

ASF GitHub Bot commented on FLINK-5014:
---------------------------------------

GitHub user melentye opened a pull request:

    https://github.com/apache/flink/pull/2760

    [FLINK-5014] [RocksDB backend] add toString for RocksDBStateBackend

    Adding toString() for RocksDBStateBackend.
    
    Example output 1:
    
    > RocksDB State Backend {isInitialized=false, configuredDbBasePaths=null, initializedDbBasePaths=null, checkpointStreamBackend=File State Backend @ file:/Users/melentye/tmp/flink-checkpoints}
    
    Example output 2:
    
    > RocksDB State Backend {isInitialized=true, configuredDbBasePaths=[/var/folders/k_/t4spznpj543cgt7vt59_6jp00000gn/T/junit6807913496462961318/junit8522690214676090832], initializedDbBasePaths=[/var/folders/k_/t4spznpj543cgt7vt59_6jp00000gn/T/junit6807913496462961318/junit8522690214676090832], checkpointStreamBackend=File State Backend @ file:/var/folders/k_/t4spznpj543cgt7vt59_6jp00000gn/T/junit6807913496462961318/junit3625485689993452525}
    
    Normally I wouldn't cover toString method with unit tests, let me know if that's something we'd like to have in this particular case.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/melentye/flink FLINK-5014-add-toString-to-RocksDBStateBackend

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2760.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2760
    
----
commit 131ce7213c4b7581a6b81ebd87683aa1375ef2df
Author: Andrey Melentyev <an...@gmail.com>
Date:   2016-11-05T07:18:38Z

    [FLINK-5014] [RocksDB backend] add toString for RocksDBStateBackend

----


> RocksDBStateBackend misses good toString
> ----------------------------------------
>
>                 Key: FLINK-5014
>                 URL: https://issues.apache.org/jira/browse/FLINK-5014
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ufuk Celebi
>
> The StreamTask logs the state backend if it is user defined.
> For RocksDB you get
> {code}
> Using user-defined state backend: org.apache.flink.contrib.streaming.state.RocksDBStateBackend@78a42aa3
> {code}
> This should be replaced with a better {{toString}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)