[jira] [Commented] (SAMZA-935) hello-samza add kafka wait for dependent services

["Navina Ramesh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242532#comment-15242532 ] 

Navina Ramesh commented on SAMZA-935:
-------------------------------------

Hi [~vishalkuo], I think it will be good idea to add the wait. In the past, I have encountered a similar issue when I was automating a test script. It will be great if you can attach the patch to the JIRA after testing your changes. Thanks!

> hello-samza add kafka wait for dependent services
> -------------------------------------------------
>
>                 Key: SAMZA-935
>                 URL: https://issues.apache.org/jira/browse/SAMZA-935
>             Project: Samza
>          Issue Type: Improvement
>          Components: hello-samza
>            Reporter: Vishal Kuo
>            Priority: Minor
>              Labels: newbie
>
> When working with a modified bin/grid script found in https://github.com/theduderog/hello-samza-confluent we found that attempting to start confluent's schemaregistry service immediately after starting the other services resulted in failure since schemaregistry is dependent on kafka which takes a couple seconds to start up.
> Would it make sense to add a wait option for kafka like we have added here: https://github.com/theduderog/hello-samza-confluent/blob/master/bin/grid#L118-L132 ? 
> {code}
> wait_kafka() {
>   echo "Waiting for kafka broker to start..."
>   until $(nc -w 2 localhost 9092); do
>     printf '.'
>     sleep 1
>   done
>   printf '\n'
>   echo "Kafka broker is listening";
> }
> {code}
> This way, dependent services started right after ./bin/grid bootsrap won't fail intermittently. 
> I don't mind adding this if it can be considered useful.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)