[REQUEST] RE: Review Request: Patch 2 : CLOUDSTACK-657 VMware vNetwork Distributed Virtual Switch support in CloudStack

[Sateesh Chodapuneedi <sa...@citrix.com>]

Hi,
I have been re-basing the patches of this VMware feature (dvSwitch) for last couple of weeks.
The latest version of it is in reviewboard.
May I request to hold on any further commit around VMware support till either this feature is committed into master or any further review comments over the patch set of this feature.

Regards,
Sateesh

From: Sateesh Chodapuneedi [mailto:noreply@reviews.apache.org] On Behalf Of Sateesh Chodapuneedi
Sent: 26 February 2013 14:37
To: Murali Reddy; Kelven Yang
Cc: Koushik Das; Sateesh Chodapuneedi; Chip Childers; cloudstack
Subject: Re: Review Request: Patch 2 : CLOUDSTACK-657 VMware vNetwork Distributed Virtual Switch support in CloudStack

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9191/


Review request for cloudstack, Murali Reddy and Kelven Yang.
By Sateesh Chodapuneedi.

Updated Feb. 26, 2013, 9:06 a.m.

Changes

One more re-base with latest master.


Description

This is 2nd patch for feature 'Support for VMware dvSwitch in CloudStack'.



This patch introduces 2 new global configuration parameters

"vmware.use.dvswitch" - Enable dvswitch functionality.

"vmware.ports.per.dvportgroup" - Default number of ports per Vmware dvPortGroup.


Testing

Manual testing:-

1) Tested guest traffic over dvSwitch on a dedicated physical network. In this case management and public traffic uses standard vSwitch on a common physical network.

2) Tested both guest traffic and public traffic over dvSwitch on a physical network.

3) Use optional parameters added to AddClusterCmd to override Zone level network traffic label. Tested 2 clusters, one with standard vSwitch and other with dvSwitch.

4) Tested all 3 traffic types on single physical network with global parameter 'vmware.use.dvswitch' set to false. This is default configuration scenario.





Added following tests,

1) Test fetching dvSwitch object from vCenter

2) Test for presence of dvPortGroup

3) Test presence of dvPortGroup

4) Test get existing dvPortGroup

5) fetch dvPortGroup configuration

6) Test compare dvPortGroup configuration

7) Test update dvPortGroup configuration

Bugs: CLOUDSTACK-657
Diffs (updated)

 *   api/src/org/apache/cloudstack/api/ApiConstants.java (0e4cbe1)
 *   api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java (7b1cd06)
 *   server/src/com/cloud/configuration/Config.java (eb6fb24)
 *   server/src/com/cloud/upgrade/dao/Upgrade410to420.java (9000e15)

View Diff<https://reviews.apache.org/r/9191/diff/>