[GitHub] [superset] john-bodley commented on a diff in pull request #24418: fix: Native filter dynamic search

["john-bodley (via GitHub)" <gi...@apache.org>]

john-bodley commented on code in PR #24418:
URL: https://github.com/apache/superset/pull/24418#discussion_r1231835157


##########
superset/models/helpers.py:
##########
@@ -1173,7 +1173,13 @@ def handle_single_value(value: Optional[FilterValue]) -> Optional[FilterValue]:
             if isinstance(value, str):
                 value = value.strip("\t\n")
 
-                if target_generic_type == utils.GenericDataType.NUMERIC:
+                if (

Review Comment:
   I'm going to turn a blind eye to the fact that this function is copy-and-pasted in multiple places. Furthermore it's rather scary there's zero unit tests for the `filter_values_handler` method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org