You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jiangxb1987 <gi...@git.apache.org> on 2018/10/11 15:39:25 UTC

[GitHub] spark issue #22165: [SPARK-25017][Core] Add test suite for BarrierCoordinato...

Github user jiangxb1987 commented on the issue:

    https://github.com/apache/spark/pull/22165
  
    Actually my original thinking was like this:
    ```
          val state = new ContextBarrierState(barrierId, numTasks)
          val requester = mockRequester()
          val request = forgeRequest(numTasks, stageId, stageAttemptId, taskAttemptId, barrierEpoch)
          state.handleRequest(requester, request)
          // Verify states
          ...
          // Verify cleanup
          ...
    ```
    So you don't have to launch a SparkContext for the test. Could you please check whether this is feasible?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org