You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/31 00:06:00 UTC
Review Request 68114: Fixed a gRPC compilation issue for Clang.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68114/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Bugs: MESOS-8395
https://issues.apache.org/jira/browse/MESOS-8395
Repository: mesos
Description
-------
When compiling gRPC with Clang, there are some array-out-of-bound
warnings due to the use of GLIBC's `__strcmp_cg` macro in the c-ares
library. With `-Werror` on, these warnings would stop gRPC from
compiling. This patch ignores such errors.
Diffs
-----
3rdparty/Makefile.am 26e5d55561731ff03639df31562bb835d9687339
Diff: https://reviews.apache.org/r/68114/diff/1/
Testing
-------
`sudo make check` with clang on ubuntu 16.04, which triggers the warnings.
Thanks,
Chun-Hung Hsiao
Re: Review Request 68114: Fixed a gRPC compilation issue for Clang.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68114/#review206681
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68091, 68074, 68092, 68114]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 31, 2018, 12:05 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68114/
> -----------------------------------------------------------
>
> (Updated July 31, 2018, 12:05 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-8395
> https://issues.apache.org/jira/browse/MESOS-8395
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When compiling gRPC with Clang, there are some array-out-of-bound
> warnings due to the use of GLIBC's `__strcmp_cg` macro in the c-ares
> library. With `-Werror` on, these warnings would stop gRPC from
> compiling. This patch ignores such errors.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 26e5d55561731ff03639df31562bb835d9687339
>
>
> Diff: https://reviews.apache.org/r/68114/diff/1/
>
>
> Testing
> -------
>
> `sudo make check` with clang on ubuntu 16.04, which triggers the warnings.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 68114: Fixed a gRPC compilation issue for Clang.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68114/#review206736
-----------------------------------------------------------
Fix it, then Ship it!
LGTM.
Two things:
* let's commit this before e.g., https://reviews.apache.org/r/68091/
* please also change this in `3rdparty/libprocess/3rdparty/Makefile.am` in a separate patch.
3rdparty/Makefile.am
Lines 432-433 (patched)
<https://reviews.apache.org/r/68114/#comment289829>
Let's mention an example of a compiler where this triggered a diagnostic.
That way we have some chance to find out whether this is still an issue in the future.
3rdparty/Makefile.am
Lines 440 (patched)
<https://reviews.apache.org/r/68114/#comment289828>
Alternatively we could just disable this diagnostic with `-Wno-array-bounds` since neither us nor our users are interested in fixing it and it just adds noise.
I do not have a very strong preference, up to you.
- Benjamin Bannier
On July 31, 2018, 2:05 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68114/
> -----------------------------------------------------------
>
> (Updated July 31, 2018, 2:05 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-8395
> https://issues.apache.org/jira/browse/MESOS-8395
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When compiling gRPC with Clang, there are some array-out-of-bound
> warnings due to the use of GLIBC's `__strcmp_cg` macro in the c-ares
> library. With `-Werror` on, these warnings would stop gRPC from
> compiling. This patch ignores such errors.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 26e5d55561731ff03639df31562bb835d9687339
>
>
> Diff: https://reviews.apache.org/r/68114/diff/1/
>
>
> Testing
> -------
>
> `sudo make check` with clang on ubuntu 16.04, which triggers the warnings.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 68114: Fixed gRPC compilation with Clang when
building Mesos.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68114/
-----------------------------------------------------------
(Updated Aug. 1, 2018, 9:49 p.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Addressed Benjamin's comments.
Summary (updated)
-----------------
Fixed gRPC compilation with Clang when building Mesos.
Bugs: MESOS-8395
https://issues.apache.org/jira/browse/MESOS-8395
Repository: mesos
Description
-------
When compiling gRPC with Clang, there are some array-out-of-bound
warnings due to the use of GLIBC's `__strcmp_cg` macro in the c-ares
library. With `-Werror` on, these warnings would stop gRPC from
compiling. This patch ignores such errors.
Diffs (updated)
-----
3rdparty/Makefile.am 26e5d55561731ff03639df31562bb835d9687339
Diff: https://reviews.apache.org/r/68114/diff/2/
Changes: https://reviews.apache.org/r/68114/diff/1-2/
Testing
-------
`sudo make check` with clang on ubuntu 16.04, which triggers the warnings.
Thanks,
Chun-Hung Hsiao
Re: Review Request 68114: Fixed a gRPC compilation issue for Clang.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68114/#review206633
-----------------------------------------------------------
FAIL: Mesos binaries failed to build.
Reviews applied: `['68091', '68074', '68092', '68114']`
Failed command: `cmake.exe --build . --config Release -- /maxcpucount`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2006/mesos-review-68114
Relevant logs:
- [mesos-binaries-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2006/mesos-review-68114/logs/mesos-binaries-cmake-stdout.log):
```
d:\dcos\mesos\3rdparty\libarchive-3.3.2\src\libarchive-3.3.2\libarchive\archive_read_support_format_7zip.c(1426): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\3rdparty\libarchive-3.3.2\src\libarchive-3.3.2-build\libarchive\archive_static.vcxproj] [D:\DCOS\mesos\3rdparty\libarchive-3.3.2.vcxproj]
d:\dcos\mesos\3rdparty\libarchive-3.3.2\src\libarchive-3.3.2\libarchive\archive_read_support_format_7zip.c(1428): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\3rdparty\libarchive-3.3.2\src\libarchive-3.3.2-build\libarchive\archive_static.vcxproj] [D:\DCOS\mesos\3rdparty\libarchive-3.3.2.vcxproj]
d:\dcos\mesos\3rdparty\libarchive-3.3.2\src\libarchive-3.3.2\libarchive\archive_write_add_filter_bzip2.c(197): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\3rdparty\libarchive-3.3.2\src\libarchive-3.3.2-build\libarchive\archive_static.vcxproj] [D:\DCOS\mesos\3rdparty\libarchive-3.3.2.vcxproj]
d:\dcos\mesos\3rdparty\libarchive-3.3.2\src\libarchive-3.3.2\libarchive\archive_write_add_filter_bzip2.c(251): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\3rdparty\libarchive-3.3.2\src\libarchive-3.3.2-build\libarchive\archive_static.vcxproj] [D:\DCOS\mesos\3rdparty\libarchive-3.3.2.vcxproj]
d:\dcos\mesos\3rdparty\libarchive-3.3.2\src\libarchive-3.3.2\libarchive\archive_write_add_filter_bzip2.c(322): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\3rdparty\libarchive-3.3.2\src\libarchive-3.3.2-build\libarchive\archive_static.vcxproj] [D:\DCOS\mesos\3rdparty\libarchive-3.3.2.vcxproj]
d:\dcos\mesos\3rdparty\libarchive-3.3.2\src\libarchive-3.3.2\libarchive\archive_write_set_format_7zip.c(1805): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\3rdparty\libarchive-3.3.2\src\libarchive-3.3.2-build\libarchive\archive_static.vcxproj] [D:\DCOS\mesos\3rdparty\libarchive-3.3.2.vcxproj]
d:\dcos\mesos\3rdparty\libarchive-3.3.2\src\libarchive-3.3.2\libarchive\archive_write_set_format_7zip.c(1809): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\3rdparty\libarchive-3.3.2\src\libarchive-3.3.2-build\libarchive\archive_static.vcxproj] [D:\DCOS\mesos\3rdparty\libarchive-3.3.2.vcxproj]
d:\dcos\mesos\3rdparty\libarchive-3.3.2\src\libarchive-3.3.2\libarchive\archive_write_set_format_7zip.c(1838): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\3rdparty\libarchive-3.3.2\src\libarchive-3.3.2-build\libarchive\archive_static.vcxproj] [D:\DCOS\mesos\3rdparty\libarchive-3.3.2.vcxproj]
d:\dcos\mesos\3rdparty\libarchive-3.3.2\src\libarchive-3.3.2\libarchive\archive_write_set_format_7zip.c(1842): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\3rdparty\libarchive-3.3.2\src\libarchive-3.3.2-build\libarchive\archive_static.vcxproj] [D:\DCOS\mesos\3rdparty\libarchive-3.3.2.vcxproj]
"D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\slave\resource_estimators\fixed_resource_estimator.vcxproj" (default target) (9) ->
"D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj" (default target) (27) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
"D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\slave\resource_estimators\fixed_resource_estimator.vcxproj" (default target) (9) ->
"D:\DCOS\mesos\src\mesos-protobufs.vcxproj" (default target) (18) ->
(CustomBuild target) ->
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 1. [D:\DCOS\mesos\src\mesos-protobufs.vcxproj]
390 Warning(s)
1 Error(s)
Time Elapsed 00:07:55.79
```
- Mesos Reviewbot Windows
On July 31, 2018, 12:05 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68114/
> -----------------------------------------------------------
>
> (Updated July 31, 2018, 12:05 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-8395
> https://issues.apache.org/jira/browse/MESOS-8395
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When compiling gRPC with Clang, there are some array-out-of-bound
> warnings due to the use of GLIBC's `__strcmp_cg` macro in the c-ares
> library. With `-Werror` on, these warnings would stop gRPC from
> compiling. This patch ignores such errors.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 26e5d55561731ff03639df31562bb835d9687339
>
>
> Diff: https://reviews.apache.org/r/68114/diff/1/
>
>
> Testing
> -------
>
> `sudo make check` with clang on ubuntu 16.04, which triggers the warnings.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>