You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/22 17:24:51 UTC
[GitHub] [spark] MaxGekk opened a new pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
MaxGekk opened a new pull request #29841:
URL: https://github.com/apache/spark/pull/29841
### What changes were proposed in this pull request?
In the PR, I propose to replace current examples for `percentile_approx()` with **only one** input value by example **with multiple values** in the input column.
### Why are the changes needed?
Current examples are pretty trivial, and don't demonstrate function's behaviour on a sequence of values.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
- by running `ExpressionInfoSuite`
- `./dev/scalastyle`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-697002111
**[Test build #128990 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128990/testReport)** for PR 29841 at commit [`e513ab5`](https://github.com/apache/spark/commit/e513ab5b870a5f8ce8d1c89ec49c798a0c99c36d).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-696867123
**[Test build #128990 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128990/testReport)** for PR 29841 at commit [`e513ab5`](https://github.com/apache/spark/commit/e513ab5b870a5f8ce8d1c89ec49c798a0c99c36d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-696993673
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-696993673
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-696867957
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-696867123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-697002634
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-696867957
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-697002642
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128990/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #29841:
URL: https://github.com/apache/spark/pull/29841
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-697186279
Here are PRs for:
- 2.4 https://github.com/apache/spark/pull/29849
- 3.0 https://github.com/apache/spark/pull/29848
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-696867957
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-696993131
**[Test build #128994 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128994/testReport)** for PR 29841 at commit [`d236c7e`](https://github.com/apache/spark/commit/d236c7e2fe8f5b6853bf0a1c9605609c9cd2b4b8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-696867957
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-696867123
**[Test build #128990 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128990/testReport)** for PR 29841 at commit [`e513ab5`](https://github.com/apache/spark/commit/e513ab5b870a5f8ce8d1c89ec49c798a0c99c36d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-697055237
Max, I think it might be better to backport to branch-2.4 and 3.0 as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-697002634
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-696993131
**[Test build #128994 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128994/testReport)** for PR 29841 at commit [`d236c7e`](https://github.com/apache/spark/commit/d236c7e2fe8f5b6853bf0a1c9605609c9cd2b4b8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-697080285
**[Test build #128994 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128994/testReport)** for PR 29841 at commit [`d236c7e`](https://github.com/apache/spark/commit/d236c7e2fe8f5b6853bf0a1c9605609c9cd2b4b8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-697055135
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-697080899
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-697055135
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-697080899
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #29841:
URL: https://github.com/apache/spark/pull/29841
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29841: [MINOR][SQL] Improve examples for `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29841:
URL: https://github.com/apache/spark/pull/29841#issuecomment-696867123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org