You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/08/06 06:27:09 UTC

[GitHub] [helix] chenboat opened a new pull request #378: Make the reservoir used in ZkClientPathMonitor metric configurable.

chenboat opened a new pull request #378: Make the reservoir used in ZkClientPathMonitor metric configurable.
URL: https://github.com/apache/helix/pull/378
 
 
   Right now it is hardcoded to use a default interval of 1hr which occupies too much memory for a busy prod helix client. Our heapdump shows as much as 4G or even higher of heap could be used for these metrics (initiated through ZkHelixPropertyStore). This creates too much memory and GC pressure. As in the manual for the SlidingTimeWindowArrayReservoir in https://metrics.dropwizard.io/4.0.0/manual/core.html, a 1 minute window could used as much as 9M of memory already. So we believe a much lower interval length should be passed in.
   
   This PR focuses primarily on fixing the case of ZkHelixPropertyStore and it can also be applied to other use cases of ZkClientPathMonitor. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org