You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/11 14:13:45 UTC

[GitHub] [arrow-datafusion] ovr opened a new issue, #3104: Panics are silently ignored in parallel execution (spawn_execution)

ovr opened a new issue, #3104:
URL: https://github.com/apache/arrow-datafusion/issues/3104

   **Describe the bug**
   
   DF uses `tokio::spawn` in `spawn_execution`  function. It uses a channel under the hood to transfer data from tasks back to the output stream. Right now, it doesn't handle panic, which causes strange behavior when the tokio show panics in logs and the output is empty.
   
   **To Reproduce**
   
   1. Introduce a new UDF function that panics
   2. Use sort to parallelize (use spawn_execution)
   
   **Expected behavior**
   
   Probably, it should return DataFushionError.
   
   cC @alamb @andygrove 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb closed issue #3104: Panics are silently ignored in parallel execution (spawn_execution)

Posted by "alamb (via GitHub)" <gi...@apache.org>.

alamb closed issue #3104: Panics are silently ignored in parallel execution (spawn_execution)
URL: https://github.com/apache/arrow-datafusion/issues/3104


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #3104: Panics are silently ignored in parallel execution (spawn_execution)

Posted by GitBox <gi...@apache.org>.

alamb commented on issue #3104:
URL: https://github.com/apache/arrow-datafusion/issues/3104#issuecomment-1212123102

   I think returning a `DataFusionError` sounds like a very reasonable thing to do
   
   When a `tokio::task` panics, it will return a `JoinError` as an error code -- perhaps somewhere datafusion does a `tokio::task::spawn` but then doesn't check for an error 🤔 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org