You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/02/22 04:23:54 UTC

[GitHub] [echarts] Ovilia opened a new pull request #14314: fix(markLine): fix axis type in markLine data and close #14300

Ovilia opened a new pull request #14314:
URL: https://github.com/apache/echarts/pull/14314


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   
   `string` is a valid type for `markLine.data` because time axis values can be string. This PR adds `string` to its type.
   
   ### Fixed issues
   
   - #14300: MarkLine1DDataItemOption incorrectly defines xAxis as number
   
   ## Details
   
   ### Before: What was the problem?
   
   Only `number` is supported for MarkLine1DDataItemOption.xAxis.
   
   
   ### After: How is it fixed in this PR?
   
   Set the type to be `number | string`.
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14314: fix(markLine): fix axis type in markLine data and close #14300

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14314:
URL: https://github.com/apache/echarts/pull/14314#issuecomment-783067773


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14314: fix(markLine): fix axis type in markLine data and close #14300

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14314:
URL: https://github.com/apache/echarts/pull/14314#issuecomment-783840738


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang merged pull request #14314: fix(markLine): fix axis type in markLine data and close #14300

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #14314:
URL: https://github.com/apache/echarts/pull/14314


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org