[GitHub] [shardingsphere] ThanoshanMV commented on pull request #13709: Add SQLServer CREATE REMOTE TABLE AS SELECT statement

[GitBox <gi...@apache.org>]

ThanoshanMV commented on pull request #13709:
URL: https://github.com/apache/shardingsphere/pull/13709#issuecomment-975174032


   Hi @strongduanmu, @tuichenchuxin. I added SQLServer `CREATE REMOTE TABLE AS SELECT` and `CREATE TABLE AS SELECT` (#13628) with the existing `CREATE TABLE` statement since the `EXPLAIN` statement's `SQL_statement` can have both of them.
   
   I defined [EXPLAIN](https://docs.microsoft.com/en-us/sql/t-sql/queries/explain-transact-sql?view=azure-sqldw-latest#syntax) statement's `SQL_statement` as:
   ```
   explainableStatement
       : select | insert | update | delete
       ;
   ```
   
   To include the `CREATE REMOTE TABLE AS SELECT` and `CREATE TABLE AS SELECT` in `EXPLAIN` statement's `SQL_statement`, can we have the definition as below:
   ```
   explainableStatement
       : select | insert | update | delete | createTable
       ;
   ```
   But it would parse standard `CREATE TABLE` statements as well. Does this approach acceptable or do you have any other suggestions? Please let me know.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org