You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kvrocks.apache.org by hulk <hu...@gmail.com> on 2022/07/15 16:52:03 UTC
[VOTE] Release Apache Kvrocks (Incubating) v2.1.0
Hi all,
This s a call for the vote to release Apache Kvrocks(incubating) v2.1.0
The release candidate:
https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.1.0/
Keys to verify the release candidate:
https://dist.apache.org/repos/dist/dev/incubator/kvrocks/KEYS
Git tag for the release:
https://github.com/apache/incubator-kvrocks/releases/tag/v2.1.0
The vote will be open for at least 72 hours or until the necessary number
of votes is reached.
If approved we will seek final release approval from the IPMC.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
--
Best Regards,
- *Hulk Lin*
Re: [VOTE] Release Apache Kvrocks (Incubating) v2.1.0
Posted by hulk <hu...@gmail.com>.
okay, thanks for tison's kind remind. I will send this vote and send the
new one based on suggestions.
On Mon, 18 Jul 2022 at 11:49, tison <wa...@gmail.com> wrote:
> I don't think the current unstable branch is a patch version to 2.0.
>
> Instead, you can create a 2.1 branch from unstable and continue the
> release.
>
> Also, if you'd like to create another release candidate, remember to cancel
> this vote before create the next RC.
>
> Best,
> tison.
>
>
> hulk <hu...@gmail.com> 于2022年7月18日周一 11:27写道：
>
> > As discussed in thread:
> > https://lists.apache.org/thread/57rpsj2wb1513f316tn7jpcnnf87czj5
> >
> > I think we can cherry-pick release commits into the branch, then use the
> > 2.0 branch to create
> > the release tag. Does it make sense? if yes, I will update tarball and
> > other assets.
> >
> > On Sun, 17 Jul 2022 at 23:29, hulk <hu...@gmail.com> wrote:
> >
> > > +1 binding for myself
> > >
> > > * I checked the GPG sign and the checksum is ok
> > > * Build from source via `./x.py build` in MacOSX is ok
> > > * Version info correct (2.1.0)
> > > * No binary files bundled
> > >
> > > On Sun, 17 Jul 2022 at 11:52, hulk <hu...@gmail.com> wrote:
> > >
> > >> Thanks, tison.
> > >>
> > >> I will also append KEYS to the right place and also have a look at
> WoT.
> > >>
> > >
> > >
> > > --
> > > Best Regards,
> > > - *Hulk Lin*
> > >
> >
> >
> > --
> > Best Regards,
> > - *Hulk Lin*
> >
>
--
Best Regards,
- *Hulk Lin*
Re: [VOTE] Release Apache Kvrocks (Incubating) v2.1.0
Posted by tison <wa...@gmail.com>.
I don't think the current unstable branch is a patch version to 2.0.
Instead, you can create a 2.1 branch from unstable and continue the release.
Also, if you'd like to create another release candidate, remember to cancel
this vote before create the next RC.
Best,
tison.
hulk <hu...@gmail.com> 于2022年7月18日周一 11:27写道：
> As discussed in thread:
> https://lists.apache.org/thread/57rpsj2wb1513f316tn7jpcnnf87czj5
>
> I think we can cherry-pick release commits into the branch, then use the
> 2.0 branch to create
> the release tag. Does it make sense? if yes, I will update tarball and
> other assets.
>
> On Sun, 17 Jul 2022 at 23:29, hulk <hu...@gmail.com> wrote:
>
> > +1 binding for myself
> >
> > * I checked the GPG sign and the checksum is ok
> > * Build from source via `./x.py build` in MacOSX is ok
> > * Version info correct (2.1.0)
> > * No binary files bundled
> >
> > On Sun, 17 Jul 2022 at 11:52, hulk <hu...@gmail.com> wrote:
> >
> >> Thanks, tison.
> >>
> >> I will also append KEYS to the right place and also have a look at WoT.
> >>
> >
> >
> > --
> > Best Regards,
> > - *Hulk Lin*
> >
>
>
> --
> Best Regards,
> - *Hulk Lin*
>
Re: [VOTE] Release Apache Kvrocks (Incubating) v2.1.0
Posted by hulk <hu...@gmail.com>.
As discussed in thread:
https://lists.apache.org/thread/57rpsj2wb1513f316tn7jpcnnf87czj5
I think we can cherry-pick release commits into the branch, then use the
2.0 branch to create
the release tag. Does it make sense? if yes, I will update tarball and
other assets.
On Sun, 17 Jul 2022 at 23:29, hulk <hu...@gmail.com> wrote:
> +1 binding for myself
>
> * I checked the GPG sign and the checksum is ok
> * Build from source via `./x.py build` in MacOSX is ok
> * Version info correct (2.1.0)
> * No binary files bundled
>
> On Sun, 17 Jul 2022 at 11:52, hulk <hu...@gmail.com> wrote:
>
>> Thanks, tison.
>>
>> I will also append KEYS to the right place and also have a look at WoT.
>>
>
>
> --
> Best Regards,
> - *Hulk Lin*
>
--
Best Regards,
- *Hulk Lin*
Re: [VOTE] Release Apache Kvrocks (Incubating) v2.1.0
Posted by hulk <hu...@gmail.com>.
+1 binding for myself
* I checked the GPG sign and the checksum is ok
* Build from source via `./x.py build` in MacOSX is ok
* Version info correct (2.1.0)
* No binary files bundled
On Sun, 17 Jul 2022 at 11:52, hulk <hu...@gmail.com> wrote:
> Thanks, tison.
>
> I will also append KEYS to the right place and also have a look at WoT.
>
--
Best Regards,
- *Hulk Lin*
Re: [VOTE] Release Apache Kvrocks (Incubating) v2.1.0
Posted by hulk <hu...@gmail.com>.
Thanks, tison.
I will also append KEYS to the right place and also have a look at WoT.
Re: [VOTE] Release Apache Kvrocks (Incubating) v2.1.0
Posted by tison <wa...@gmail.com>.
Another tip is that you KEY are not in the Web of Trust among Apache
committers. I don't regard it as a blocker but you can refer to these docs
for trying to join the WoT.
https://infra.apache.org/openpgp.html#wot
https://infra.apache.org/release-signing.html#web-of-trust
That said, when I verify the tarball, it gives:
gpg: Signature made 六 7/16 00:39:55 2022 CST
gpg: using RSA key F77B887A4F25A9468C513E9AA3008E49B00F626B
gpg: Good signature from "hulk <hu...@apache.org>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the
owner.
Primary key fingerprint: F77B 887A 4F25 A946 8C51 3E9A A300 8E49 B00F 626B
If you're in the WoT, the WARNING line should vanish.
Best,
tison.
tison <wa...@gmail.com> 于2022年7月17日周日 11:30写道：
> +1 binding
>
> * Checksum and GPG sign correct
> * LICENSE, NOTICE and DISCLAIMER files exist
> * Build from source via `./x.py build --ninja`
> * Version info correct (2.1.0)
> * Communicate kvrocks with redis-cli and all things fine.
> * No binary files bundled.
>
> However, I'm unsure when we properly convey bundled staff licenses and
> notices according to https://infra.apache.org/licensing-howto.html.
> Perhaps @hexiaoqiao@apache.org <he...@apache.org> can help verify
> this part.
>
> Best,
> tison.
>
>
> tison <wa...@gmail.com> 于2022年7月17日周日 10:27写道：
>
>> Hi hulk,
>>
>> Before verify the content, one issue (not a blocker) you can improve:
>>
>> Append your KEY to
>> https://dist.apache.org/repos/dist/release/incubator/kvrocks/KEYS
>> instead of /dev/ path. The entry under /release/ is required and we don't
>> have to maintain two entries.
>>
>> Best,
>> tison.
>>
>>
>> Myth <cp...@gmail.com> 于2022年7月16日周六 09:45写道：
>>
>>> +1
>>>
>>> hulk <hu...@gmail.com> 于2022年7月16日周六 00:52写道：
>>>
>>> > Hi all,
>>> >
>>> > This s a call for the vote to release Apache Kvrocks(incubating) v2.1.0
>>> >
>>> > The release candidate:
>>> >
>>> > https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.1.0/
>>> >
>>> >
>>> > Keys to verify the release candidate:
>>> >
>>> > https://dist.apache.org/repos/dist/dev/incubator/kvrocks/KEYS
>>> >
>>> >
>>> > Git tag for the release:
>>> >
>>> > https://github.com/apache/incubator-kvrocks/releases/tag/v2.1.0
>>> >
>>> >
>>> > The vote will be open for at least 72 hours or until the necessary
>>> number
>>> > of votes is reached.
>>> >
>>> >
>>> > If approved we will seek final release approval from the IPMC.
>>> >
>>> >
>>> > Please vote accordingly:
>>> >
>>> > [ ] +1 approve
>>> >
>>> > [ ] +0 no opinion
>>> >
>>> > [ ] -1 disapprove with the reason
>>> >
>>> > --
>>> > Best Regards,
>>> > - *Hulk Lin*
>>> >
>>>
>>
Re: [VOTE] Release Apache Kvrocks (Incubating) v2.1.0
Posted by tison <wa...@gmail.com>.
+1 binding
* Checksum and GPG sign correct
* LICENSE, NOTICE and DISCLAIMER files exist
* Build from source via `./x.py build --ninja`
* Version info correct (2.1.0)
* Communicate kvrocks with redis-cli and all things fine.
* No binary files bundled.
However, I'm unsure when we properly convey bundled staff licenses and
notices according to https://infra.apache.org/licensing-howto.html. Perhaps
@hexiaoqiao@apache.org <he...@apache.org> can help verify this part.
Best,
tison.
tison <wa...@gmail.com> 于2022年7月17日周日 10:27写道：
> Hi hulk,
>
> Before verify the content, one issue (not a blocker) you can improve:
>
> Append your KEY to
> https://dist.apache.org/repos/dist/release/incubator/kvrocks/KEYS instead
> of /dev/ path. The entry under /release/ is required and we don't have to
> maintain two entries.
>
> Best,
> tison.
>
>
> Myth <cp...@gmail.com> 于2022年7月16日周六 09:45写道：
>
>> +1
>>
>> hulk <hu...@gmail.com> 于2022年7月16日周六 00:52写道：
>>
>> > Hi all,
>> >
>> > This s a call for the vote to release Apache Kvrocks(incubating) v2.1.0
>> >
>> > The release candidate:
>> >
>> > https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.1.0/
>> >
>> >
>> > Keys to verify the release candidate:
>> >
>> > https://dist.apache.org/repos/dist/dev/incubator/kvrocks/KEYS
>> >
>> >
>> > Git tag for the release:
>> >
>> > https://github.com/apache/incubator-kvrocks/releases/tag/v2.1.0
>> >
>> >
>> > The vote will be open for at least 72 hours or until the necessary
>> number
>> > of votes is reached.
>> >
>> >
>> > If approved we will seek final release approval from the IPMC.
>> >
>> >
>> > Please vote accordingly:
>> >
>> > [ ] +1 approve
>> >
>> > [ ] +0 no opinion
>> >
>> > [ ] -1 disapprove with the reason
>> >
>> > --
>> > Best Regards,
>> > - *Hulk Lin*
>> >
>>
>
Re: [VOTE] Release Apache Kvrocks (Incubating) v2.1.0
Posted by tison <wa...@gmail.com>.
Hi hulk,
Before verify the content, one issue (not a blocker) you can improve:
Append your KEY to
https://dist.apache.org/repos/dist/release/incubator/kvrocks/KEYS instead
of /dev/ path. The entry under /release/ is required and we don't have to
maintain two entries.
Best,
tison.
Myth <cp...@gmail.com> 于2022年7月16日周六 09:45写道：
> +1
>
> hulk <hu...@gmail.com> 于2022年7月16日周六 00:52写道：
>
> > Hi all,
> >
> > This s a call for the vote to release Apache Kvrocks(incubating) v2.1.0
> >
> > The release candidate:
> >
> > https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.1.0/
> >
> >
> > Keys to verify the release candidate:
> >
> > https://dist.apache.org/repos/dist/dev/incubator/kvrocks/KEYS
> >
> >
> > Git tag for the release:
> >
> > https://github.com/apache/incubator-kvrocks/releases/tag/v2.1.0
> >
> >
> > The vote will be open for at least 72 hours or until the necessary number
> > of votes is reached.
> >
> >
> > If approved we will seek final release approval from the IPMC.
> >
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> >
> > [ ] +0 no opinion
> >
> > [ ] -1 disapprove with the reason
> >
> > --
> > Best Regards,
> > - *Hulk Lin*
> >
>
Re: [VOTE] Release Apache Kvrocks (Incubating) v2.1.0
Posted by Myth <cp...@gmail.com>.
+1
hulk <hu...@gmail.com> 于2022年7月16日周六 00:52写道：
> Hi all,
>
> This s a call for the vote to release Apache Kvrocks(incubating) v2.1.0
>
> The release candidate:
>
> https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.1.0/
>
>
> Keys to verify the release candidate:
>
> https://dist.apache.org/repos/dist/dev/incubator/kvrocks/KEYS
>
>
> Git tag for the release:
>
> https://github.com/apache/incubator-kvrocks/releases/tag/v2.1.0
>
>
> The vote will be open for at least 72 hours or until the necessary number
> of votes is reached.
>
>
> If approved we will seek final release approval from the IPMC.
>
>
> Please vote accordingly:
>
> [ ] +1 approve
>
> [ ] +0 no opinion
>
> [ ] -1 disapprove with the reason
>
> --
> Best Regards,
> - *Hulk Lin*
>