You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/06/11 14:09:31 UTC

[GitHub] [calcite] rubenada commented on a change in pull request #1261: [CALCITE-3119] Deprecate Linq4j CorrelateJoinType (in favor of JoinType)

rubenada commented on a change in pull request #1261: [CALCITE-3119] Deprecate Linq4j CorrelateJoinType (in favor of JoinType)
URL: https://github.com/apache/calcite/pull/1261#discussion_r292475722
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java
 ##########
 @@ -168,7 +172,7 @@ public CorrelateJoinType toLinq4jCorrelateJoinType() {
         "Unable to convert " + this + " to CorrelateJoinType");
   }
 
-  /** Transform this JoinRelType to Linq4j JoinType. **/
+  /** Transforms this JoinRelType to Linq4j JoinType. **/
   public JoinType toLinq4jJoinType() {
 
 Review comment:
   Ok for me to move this method to EnumUtils.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services