You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/06/28 10:59:20 UTC

[GitHub] [incubator-kyuubi] cxzl25 commented on a diff in pull request #2957: [SUB-TASK][KPIP-4] Use canonical host name for kyuubi instance

cxzl25 commented on code in PR #2957:
URL: https://github.com/apache/incubator-kyuubi/pull/2957#discussion_r908341306


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala:
##########
@@ -56,7 +56,7 @@ class KyuubiRestFrontendService(override val serverable: Serverable)
 
   override def initialize(conf: KyuubiConf): Unit = synchronized {
     val host = conf.get(FRONTEND_REST_BIND_HOST)
-      .getOrElse(Utils.findLocalInetAddress.getHostAddress)
+      .getOrElse(Utils.findLocalInetAddress.getCanonicalHostName)

Review Comment:
   `TFrontendService` should have a similar problem.
   We encountered this problem when upgrading 1.5 and changed to `getCanonicalHostName`
   I see that `KyuubiMySQLFrontendService` still uses `getCanonicalHostName`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org