[jira] [Resolved] (DRILL-2448) Remove outdated code to ignore type resolution with varchar vs varbinary now that implicit casting subsumes it

["Jason Altekruse (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DRILL-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Altekruse resolved DRILL-2448.
------------------------------------
       Resolution: Fixed
    Fix Version/s:     (was: 1.0.0)
                   0.9.0

Fixed in a49b99ff1a679a0dfb696686d62449edbb231f37

> Remove outdated code to ignore type resolution with varchar vs varbinary now that implicit casting subsumes it
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-2448
>                 URL: https://issues.apache.org/jira/browse/DRILL-2448
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Data Types
>    Affects Versions: 0.7.0
>            Reporter: Jason Altekruse
>            Assignee: Jason Altekruse
>            Priority: Critical
>             Fix For: 0.9.0
>
>         Attachments: DRILL-2448-varchar-varbinary-implicit-cast.patch
>
>
> Function resolution included a small condition to allow varchar and varbinary functions to be resolved for either incoming type. While it is valid to implicitly cast between these two, this early workaround creates a technically invalid expression tree that happens to work with the current code generation system. This however does create an issue for the interpreted expression evaluator. Removing the code simply causes an implicit cast to be added during materialization, this works for both generated code expression evaluation as well as the interpreter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)