You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/23 02:07:28 UTC

[GitHub] [skywalking] hutaishi opened a new issue, #8936: [Feature] skywalking grpc plugin support trace client async call

hutaishi opened a new issue, #8936:
URL: https://github.com/apache/skywalking/issues/8936

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   My service is using grpc for asynchronous calls and I found that I could not trace the asynchronous calls. I researched the grpc plugin source code and found that only synchronous calls are tracked. The code is as follows：
   ### skywalking grpc:
   ![HFA3S@K2636~DU1@B%IBMKM](https://user-images.githubusercontent.com/12478263/164863000-701ea797-3078-4a73-a33c-d10e3fd82f83.png)
   
   ### io.grpc.stub.ClientCalls  async call or sync call:
   ![image](https://user-images.githubusercontent.com/12478263/164863212-b97c33be-5fac-4aa8-b9ef-03444644b097.png)
   
   
   ### Use case
   
   Want to be able to track asynchronous calls without breaking the trace.
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] hutaishi commented on issue #8936: [Feature] skywalking grpc plugin support trace client async call

Posted by GitBox <gi...@apache.org>.
hutaishi commented on issue #8936:
URL: https://github.com/apache/skywalking/issues/8936#issuecomment-1107462597

   > AFAIK, grpc async(stream) is not supported.
   
   After my testing, all 4 call methods are supported.
   ## UNARY
   ![QWA6}JO{JJF13JSWGWS31_A](https://user-images.githubusercontent.com/12478263/164893877-e4137432-671c-46ab-8b6a-d8b1a8c8a597.png)
   
   ![image](https://user-images.githubusercontent.com/12478263/164893930-15f7cbe9-e226-4f0a-88fa-a03975af18e4.png)
   
   ## CLIENT_STREAMING
   ![image](https://user-images.githubusercontent.com/12478263/164893964-588b91e1-a958-499a-9e47-8e25fa2e6d60.png)
   
   ## SERVER_STREAMING
   ![image](https://user-images.githubusercontent.com/12478263/164894017-109dbe12-c4c4-421b-9736-797812d9d235.png)
   
   ## BIDI_STREAMING
   ![image](https://user-images.githubusercontent.com/12478263/164894046-6b93e4b8-3fdd-4c3b-9529-e4f888c8f00d.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] hutaishi commented on issue #8936: [Feature] skywalking grpc plugin support trace client generic call

Posted by GitBox <gi...@apache.org>.
hutaishi commented on issue #8936:
URL: https://github.com/apache/skywalking/issues/8936#issuecomment-1112248403

   > @hutaishi Any plan to continue? Would you fix gRPC plugin first?
   
   
   I'm doing my best to do this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] hutaishi commented on issue #8936: [Feature] skywalking grpc plugin support trace client async call

Posted by GitBox <gi...@apache.org>.
hutaishi commented on issue #8936:
URL: https://github.com/apache/skywalking/issues/8936#issuecomment-1107463830

   My interception points are as follows：
   
   - class: io.grpc.internal.ClientCallImpl
   - instance method: start
   All calls will go through the start method.
   Create exitspan in the start method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #8936: [Feature] skywalking grpc plugin support trace client generic call

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #8936: [Feature] skywalking grpc plugin support trace client generic call
URL: https://github.com/apache/skywalking/issues/8936


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #8936: [Feature] skywalking grpc plugin support trace client async call

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8936:
URL: https://github.com/apache/skywalking/issues/8936#issuecomment-1107354225

   AFAIK, grpc async(stream) is not supported.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #8936: [Feature] skywalking grpc plugin support trace client async call

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8936:
URL: https://github.com/apache/skywalking/issues/8936#issuecomment-1111865037

   @hutaishi Any plan to continue? Would you fix gRPC plugin first?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org