You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/08 09:04:49 UTC
[GitHub] [tvm] MichaelJKlaiber opened a new pull request, #12731: [BugFix][UMA] Bugfix of target attr and fixed link in tutorial
MichaelJKlaiber opened a new pull request, #12731:
URL: https://github.com/apache/tvm/pull/12731
There was a flaw in UMA backend.py that triggered an error when for passing target attributes. It is fixed.
A link in the UMA tutorial was broken and fixed by this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #12731: [BugFix][UMA] Bugfix of target attr and fixed link in tutorial
Posted by GitBox <gi...@apache.org>.
areusch commented on PR #12731:
URL: https://github.com/apache/tvm/pull/12731#issuecomment-1248632486
thanks @MichaelJKlaiber ! agreed with the others that it would be great if we could update the test to cover this case as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on pull request #12731: [BugFix][UMA] Bugfix of target attr and fixed link in tutorial
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on PR #12731:
URL: https://github.com/apache/tvm/pull/12731#issuecomment-1354765046
Closing as this PR is superseded by #13624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupak commented on a diff in pull request #12731: [BugFix][UMA] Bugfix of target attr and fixed link in tutorial
Posted by GitBox <gi...@apache.org>.
manupak commented on code in PR #12731:
URL: https://github.com/apache/tvm/pull/12731#discussion_r970760561
##########
python/tvm/relay/backend/contrib/uma/backend.py:
##########
@@ -278,7 +278,7 @@ def register(self) -> None:
"""
registration_func = tvm.get_global_func("relay.backend.contrib.uma.RegisterTarget")
- for name, attr in self._target_attrs:
+ for name, attr in self._target_attrs.items():
Review Comment:
Maybe because this was too generic (though I expect that to be some sort of TypeError) : https://github.com/apache/tvm/blob/2aa0d1fbfcf4a31e343cc6852fdc4abd660c850a/tests/python/contrib/test_uma/test_target.py#L72.
Should we make sure that we catch the correct exception ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] MichaelJKlaiber commented on pull request #12731: [BugFix][UMA] Bugfix of target attr and fixed link in tutorial
Posted by GitBox <gi...@apache.org>.
MichaelJKlaiber commented on PR #12731:
URL: https://github.com/apache/tvm/pull/12731#issuecomment-1245170081
@areusch, @manupak , what are your 2cents here?
This seems like a minor fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cbalint13 commented on pull request #12731: [BugFix][UMA] Bugfix of target attr and fixed link in tutorial
Posted by GitBox <gi...@apache.org>.
cbalint13 commented on PR #12731:
URL: https://github.com/apache/tvm/pull/12731#issuecomment-1347185506
@MichaelJKlaiber
* The bug was quite trivial for UMA, thanks for the fix !
@areusch , @manupak,
* LGTM, confirming that in real practice the issue is fixed.
Can we move forward and merge this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on a diff in pull request #12731: [BugFix][UMA] Bugfix of target attr and fixed link in tutorial
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on code in PR #12731:
URL: https://github.com/apache/tvm/pull/12731#discussion_r966003184
##########
python/tvm/relay/backend/contrib/uma/backend.py:
##########
@@ -278,7 +278,7 @@ def register(self) -> None:
"""
registration_func = tvm.get_global_func("relay.backend.contrib.uma.RegisterTarget")
- for name, attr in self._target_attrs:
+ for name, attr in self._target_attrs.items():
Review Comment:
Thanks for the fix @MichaelJKlaiber, just curious why this didn't get caught by https://github.com/apache/tvm/blob/main/tests/python/contrib/test_uma/test_target.py#L68?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #12731: [BugFix][UMA] Bugfix of target attr and fixed link in tutorial
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #12731:
URL: https://github.com/apache/tvm/pull/12731#discussion_r1029463198
##########
python/tvm/relay/backend/contrib/uma/backend.py:
##########
@@ -278,7 +278,7 @@ def register(self) -> None:
"""
registration_func = tvm.get_global_func("relay.backend.contrib.uma.RegisterTarget")
- for name, attr in self._target_attrs:
+ for name, attr in self._target_attrs.items():
Review Comment:
+1 to @manupak's suggestion; can we either use TVMError or a subclass of that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] MichaelJKlaiber commented on pull request #12731: [BugFix][UMA] Bugfix of target attr and fixed link in tutorial
Posted by GitBox <gi...@apache.org>.
MichaelJKlaiber commented on PR #12731:
URL: https://github.com/apache/tvm/pull/12731#issuecomment-1240437628
@cgerum @areusch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 closed pull request #12731: [BugFix][UMA] Bugfix of target attr and fixed link in tutorial
Posted by GitBox <gi...@apache.org>.
lhutton1 closed pull request #12731: [BugFix][UMA] Bugfix of target attr and fixed link in tutorial
URL: https://github.com/apache/tvm/pull/12731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org